<table><tr><td style="">hpereiradacosta accepted this revision.<br />hpereiradacosta added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D26217">View Revision</a></tr></table><br /><div><div><p>looks good. See comment about the symbol pen width change and then ship it.</p>
<blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D26217#583358" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D26217#583358</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>...And after these patches land, let's do the doxygen-friendly comment formatting all at once in another patch.</p></div>
</blockquote>
<p>Most comments should already be doxygen friendly in breeze, except that <em>* and /** are used instead of </em>/</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26217#inline-147851">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breeze.h:180</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// The standard pen stroke width for symbols.</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">static</span> <span class="n">constexpr</span> <span class="n">qreal</span> <span class="n">Symbol</span> <span style="color: #aa2211">=</span> <span style="color: #601200">1.01</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">For the record, <em>* (and /**) should also be caught by Doxygen (and hopefully KDevelop). It is used more or less systematically in oxygen, so please use this instead of </em>/</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D26217#inline-147850">View Inline</a><span style="color: #4b4d51; font-weight: bold;">breezehelper.cpp:1355</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">pen</span><span class="p">.</span><span class="n">setJoinStyle</span><span class="p">(</span> <span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">MiterJoin</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">pen</span><span class="p">.</span><span class="n">setWidthF</span><span class="p">(</span> <span class="bright"></span><span style="color: #601200"><span class="bright">1.1</span></span><span style="color: #aa2211">*</span><span class="n">qMax</span><span class="p">(</span><span style="color: #601200">1.0</span><span class="p">,</span> <span style="color: #601200">18.0</span><span style="color: #aa2211">/</span><span class="n">rect</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">pen</span><span class="p">.</span><span class="n">setWidthF</span><span class="p">(</span> <span class="bright"></span><span class="n"><span class="bright">PenWidth</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">::</span></span><span class="bright"></span><span class="n"><span class="bright">Symbol</span></span><span style="color: #aa2211">*</span><span class="n">qMax</span><span class="p">(</span><span style="color: #601200">1.0</span><span class="p">,</span> <span style="color: #601200">18.0</span><span style="color: #aa2211">/</span><span class="n">rect</span><span class="p">.</span><span class="n">width</span><span class="p">()</span> <span class="p">)</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">painter</span><span style="color: #aa2211">-></span><span class="n">setPen</span><span class="p">(</span> <span class="n">pen</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Here the penwidth is actually changed (from 1.1 to 1.01) this could affect the appearance of the actual buttons. Are you happy with the new appearance ? <br />
Also, should doublecheck that this is consistent with button rendering in the decoration.</p>
<p style="padding: 0; margin: 8px;">In fact for the sake of changing only one thing at a time, I would set penwidth::Symbol to 1.1</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>BRANCH</strong><div><div>replace-hardcoded (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D26217">https://phabricator.kde.org/D26217</a></div></div><br /><div><strong>To: </strong>ndavis, Breeze, Plasma, hpereiradacosta, ngraham<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>