<table><tr><td style="">ngraham added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22176">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22176#inline-146681">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigGeneral.qml:101</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">enabled:</span> <span style="color: #aa2211">!</span><span style="color: #004012">showAllCheckBox</span><span class="p">.</span><span style="color: #004012">checked</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">model:</span> <span style="color: #004012">isPlasmoid</span> <span style="color: #aa2211">?</span> <span class="p">[</span><span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Auto"</span><span class="p">),</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Shown"</span><span class="p">),</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Hidden"</span><span class="p">),</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Disabled"</span><span class="p">)]</span> <span style="color: #aa2211">:</span> <span class="p">[</span><span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Auto"</span><span class="p">),</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Shown"</span><span class="p">),</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Hidden"</span><span class="p">)]</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">While we're at it, I might suggest using visibility strings that are bit more obvious about their purpose. In particular "Auto" has the same issue as "Smart" in that it's not clear what it actually does. I might propose something like this:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">Always shown
Shown while in use/when relevant/something like that
Only shown in pop-up
Disabled</pre></div></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22176">https://phabricator.kde.org/D22176</a></div></div><br /><div><strong>To: </strong>nicolasfella, Plasma, VDG<br /><strong>Cc: </strong>kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>