<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25920">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25920#576966" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D25920#576966</a>, <a href="https://phabricator.kde.org/p/abetts/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@abetts</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Suggestions:</p>
<p>"To reduce eye strain, Night Color makes the colors on the screen warmer at the time of your choosing"</p>
<p>Change to:</p>
<p>"Night Color makes the screen colors warmer to reduce eye strain"</p></div>
</blockquote>
<p>That eliminates the "at the time of your choosing", bit, without which I worry that users might mistakenly believe that this feature permanently tints the screen while on, missing the entire point that it does this on;y at certain times of day.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>"Night color temperature"</p>
<p>Change to:</p>
<p>"Temperature"</p></blockquote>
<p>Or maybe even... "Color"?</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><ul class="remarkup-list">
<li class="remarkup-list-item">Sunset/sunrise at manual location
<br /><br />
Change to:</li>
<li class="remarkup-list-item">Sunset to sunrise at different location</li>
</ul></blockquote>
<p>Other proposed changes seem fine, but this would make that feature misleading, I feat. My first iteration of this patch used "different location", but upon reflection and consultation with the developers, using a location other than your own makes no sense whatsoever. The point of the manual location entry is to enter your own location without needing to use the geolocator in the case that it's broken or you're very privacy-conscious. There are no valid user use cases to living in Australia and setting the location to Canada.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Instead of having latitude/longitude + Detect Location, swap to Detect Location + Lat/long after.</p></blockquote>
<p>Good idea!</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>"Color change begins at XX:XX"</p>
<p>Change to:</p>
<p>Night color begins at XX;XX</p>
<p>Color fully changed, might not be necessary? Too much detail?</p>
<p>"Color begins changing back at XX:XX"</p>
<p>Change to</p>
<p>Night color ends XX:XX</p>
<p>Normal coloration restored by XX:XX, might be too much info.</p></blockquote>
<p>Because of the lengthy transition time, if we just list the time when it starts, people will get confused because they'll say, "hey, this thing says it's on, but I don't see any color change!" because the color has just started changing and has not finished the transition yet.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Since the color changes gradually, maybe we could add an option to enable/disable that function? Something like</p>
<ul class="remarkup-list remarkup-list-with-checkmarks">
<li class="remarkup-list-item remarkup-checked-item"><input type="checkbox" checked="checked" disabled="disabled" /> Gradual activation</li>
<li class="remarkup-list-item remarkup-checked-item"><input type="checkbox" checked="checked" disabled="disabled" /> Change colors gradually</li>
</ul></blockquote>
<p>There is, when using manual times mode. In that mode, you can choose the transition time. When using a location-based mode, this isn't user-selectable because the transition time is perfectly coordinated to come on when the sun starts to set and complete when it's dark. It doesn't make sense to let the user override that when in a location-based mode.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>polish-nightcolor-ui (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25920">https://phabricator.kde.org/D25920</a></div></div><br /><div><strong>To: </strong>ngraham, VDG, Plasma, davidedmundson, romangg<br /><strong>Cc: </strong>abetts, romangg, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart<br /></div>