<table><tr><td style="">fvogt requested changes to this revision.<br />fvogt added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25466">View Revision</a></tr></table><br /><div><div><p>IMO this should be addressed outside of PBI instead:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">If a captive portal is detected, call <tt style="background: #ebebeb; font-size: 13px;">CheckConnectivity</tt> with a higher frequency (I've never had any issues with this, actually)</li>
<li class="remarkup-list-item">Instead of opening <tt style="background: #ebebeb; font-size: 13px;">networkcheck.kde.org</tt> in the browser when clicking the "Log In" button, open a page which just closes itself</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25466">https://phabricator.kde.org/D25466</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, bcooksley, fvogt, jgrulich<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>