<table><tr><td style="">sitter created this revision.<br />sitter added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />sitter requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25191">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>the bespoke parser was a horrendous drain on the build time of<br />
plasma-desktop due to recursive templates.<br />
it's been replaced with a new standalone binary that previews any<br />
model/layout/variant/options combination as requested and a qtquick UI<br />
which simplifies the actual rendering substantially.</p>

<p>the new code is better in that it:</p>

<ul class="remarkup-list">
<li class="remarkup-list-item">builds in a fraction of the time with a fraction of the power use</li>
<li class="remarkup-list-item">renders complex models (such as the tm2020 or the kinesis) correctly</li>
<li class="remarkup-list-item">because it entirely relies on xkb to figure out keysyms belonging to a given key, it's layout representation is not only substantially more complete it also correctly obeys options like eurosign:2</li>
<li class="remarkup-list-item">renders numlock and the like (not that this is in fact very useful ^^)</li>
<li class="remarkup-list-item">is following the system palette for coloring</li>
<li class="remarkup-list-item">the paint code should be easier to graps and more robust because xkb provides completely consistent geometry and layout data meaning we can model this verbatim in qtquick and then scale the entire keyboard to a useful size</li>
<li class="remarkup-list-item">this is now a standalone application so potential input method KCMs can opt to use it (e.g. fcitx)</li>
</ul></div></div><br /><div><strong>TEST PLAN</strong><div><p>preview all the layouts and all the models</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>master</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25191">https://phabricator.kde.org/D25191</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcms/keyboard/CMakeLists.txt<br />
kcms/keyboard/config-keyboard.h.cmake<br />
kcms/keyboard/kcm_add_layout_dialog.cpp<br />
kcms/keyboard/kcm_add_layout_dialog.h<br />
kcms/keyboard/kcm_keyboard_widget.cpp<br />
kcms/keyboard/kcm_keyboard_widget.h<br />
kcms/keyboard/preview/TODO<br />
kcms/keyboard/preview/geometry_components.cpp<br />
kcms/keyboard/preview/geometry_components.h<br />
kcms/keyboard/preview/geometry_parser.cpp<br />
kcms/keyboard/preview/geometry_parser.h<br />
kcms/keyboard/preview/kbpreviewframe.cpp<br />
kcms/keyboard/preview/kbpreviewframe.h<br />
kcms/keyboard/preview/keyaliases.cpp<br />
kcms/keyboard/preview/keyaliases.h<br />
kcms/keyboard/preview/keyboardlayout.cpp<br />
kcms/keyboard/preview/keyboardlayout.h<br />
kcms/keyboard/preview/keyboardpainter.cpp<br />
kcms/keyboard/preview/keyboardpainter.h<br />
kcms/keyboard/preview/keysym2ucs.cpp<br />
kcms/keyboard/preview/keysym2ucs.h<br />
kcms/keyboard/preview/keysymbols.cpp<br />
kcms/keyboard/preview/keysymbols.h<br />
kcms/keyboard/preview/keysymhelper.cpp<br />
kcms/keyboard/preview/keysymhelper.h<br />
kcms/keyboard/preview/symbol_parser.cpp<br />
kcms/keyboard/preview/symbol_parser.h<br />
kcms/keyboard/tastenbrett.cpp<br />
kcms/keyboard/tastenbrett.h<br />
kcms/keyboard/tastenbrett/CMakeLists.txt<br />
kcms/keyboard/tastenbrett/README.md<br />
kcms/keyboard/tastenbrett/application.cpp<br />
kcms/keyboard/tastenbrett/application.h<br />
kcms/keyboard/tastenbrett/doodad.cpp<br />
kcms/keyboard/tastenbrett/doodad.h<br />
kcms/keyboard/tastenbrett/foobar.cpp<br />
kcms/keyboard/tastenbrett/foobar.h<br />
kcms/keyboard/tastenbrett/geometry.cpp<br />
kcms/keyboard/tastenbrett/geometry.h<br />
kcms/keyboard/tastenbrett/key.cpp<br />
kcms/keyboard/tastenbrett/key.h<br />
kcms/keyboard/tastenbrett/main.cpp<br />
kcms/keyboard/tastenbrett/outline.cpp<br />
kcms/keyboard/tastenbrett/outline.h<br />
kcms/keyboard/tastenbrett/qml.qrc<br />
kcms/keyboard/tastenbrett/qml/IndicatorDoodad.qml<br />
kcms/keyboard/tastenbrett/qml/Key.qml<br />
kcms/keyboard/tastenbrett/qml/KeyCap.qml<br />
kcms/keyboard/tastenbrett/qml/KeyCapLabel.qml<br />
kcms/keyboard/tastenbrett/qml/ShapeCanvas.qml<br />
kcms/keyboard/tastenbrett/qml/ShapeDoodad.qml<br />
kcms/keyboard/tastenbrett/qml/TextDoodad.qml<br />
kcms/keyboard/tastenbrett/qml/main.qml<br />
kcms/keyboard/tastenbrett/row.cpp<br />
kcms/keyboard/tastenbrett/row.h<br />
kcms/keyboard/tastenbrett/section.cpp<br />
kcms/keyboard/tastenbrett/section.h<br />
kcms/keyboard/tastenbrett/shape.cpp<br />
kcms/keyboard/tastenbrett/shape.h<br />
kcms/keyboard/tastenbrett/xkbobject.cpp<br />
kcms/keyboard/tastenbrett/xkbobject.h<br />
kcms/keyboard/tests/CMakeLists.txt<br />
kcms/keyboard/tests/geometry_parser_test.cpp<br />
kcms/keyboard/xkb_rules.cpp<br />
kcms/keyboard/xkb_rules.h</div></div></div><br /><div><strong>To: </strong>sitter, Plasma<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>