<table><tr><td style="">filipf added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D25043">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D25043#556015" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: line-through;">D25043#556015</a>, <a href="https://phabricator.kde.org/p/davidedmundson/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p><span class="phabricator-remarkup-mention-unknown">@kbroulik</span> we should try to wait if there is an ongoing discussion.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>I have the latest package installed in KDE Neon Dev Unstable, does it need to be compiled instead for some very recent change?</p></blockquote>
<p>Yes, there's a partner patch adding a disabledText role to Plasma theme to bring it in line with kirigami.<br />
I think Neon builds once every night? If you don't have it your console will be spewing errors saying "no such role"</p></div>
</blockquote>
<p>I don't get that error when running plasmashell and kwin in the console, but I'll build plasma-frameworks later tonight and see if that fixes it.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">we have no control over color schemes; they might have dumb values for this color; in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme:</pre></div></blockquote>
<p>This is a very valid point, but any colour scheme should define a disabledText colour as QWidgets and Kirigami will be using that.<br />
Do we have any colour schemes which are used only in plasma?</p></blockquote>
<p>Hmm not sure, I'll test a bunch of them later on when plasma-framework compiles.</p>
<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Isn't DescriptiveLabel just a label (a QQC1 based at that) with 0.6 opacity when inactive?</p></blockquote>
<p>QQC1 Label and QQC2 labels are both Text directly, so not a huge difference. We should upgrade it though.<br />
Also yes, we should change DescriptiveLabel</p></blockquote>
<p>Seems like it would be good then to add DescriptiveLabel to PC3 and set <tt style="background: #ebebeb; font-size: 13px;">color: theme.disabledTextColor</tt> there and replace all labels which need such treatment (including here) with it? One problem I see though is how do we achieve the inactive vs. active effect that was now done with the 0.6 : 0.8 trick.</p>
<p>FWIW I don't mind moving away from opacity, just wanted to check if it'll work right and if we'll be implementing it elsewhere. It will also help us work around the Qt bug whereby label opacity fails with NativeRendering when the dialog is quite transparent.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R112 Milou</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D25043">https://phabricator.kde.org/D25043</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG, davidedmundson<br /><strong>Cc: </strong>filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>