<table><tr><td style="">ervin requested changes to this revision.<br />ervin added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24917">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24917#inline-140779">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcmstyle.cpp:317</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">m_model</span><span style="color: #aa2211">-></span><span class="n">setSelectedStyle</span><span class="p">(</span><span class="n">m_settings</span><span style="color: #aa2211">-></span><span class="n">widgetStyle</span><span class="p">());</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">That line and the metaenum wrangling could likely be factored out somehow and shared with load(). Especially the enum part is uncommon enough that we probably want to hide it behind a nicer name (also would help a bit having a more consistent level of abstraction in the code of those functions).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24917#inline-140776">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcmstyle.h:48</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">StylesModel</span> <span style="color: #aa2211">*</span><span class="n">model</span> <span class="n">READ</span> <span class="n">model</span> <span class="n">CONSTANT</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">Q_PROPERTY</span><span class="p">(</span><span style="color: #aa4000">bool</span> <span class="n">iconsOnButtons</span> <span class="n">READ</span> <span class="n">iconsOnButtons</span> <span class="n">WRITE</span> <span class="n">setIconsOnButtons</span> <span class="n">NOTIFY</span> <span class="n">iconsOnButtonsChanged</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">Q_PROPERTY</span><span class="p">(</span><span style="color: #aa4000">bool</span> <span class="n">iconsInMenus</span> <span class="n">READ</span> <span class="n">iconsInMenus</span> <span class="n">WRITE</span> <span class="n">setIconsInMenus</span> <span class="n">NOTIFY</span> <span class="n">iconsInMenusChanged</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright"> </span><span class="n"><span class="bright">Q_PROPERTY</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span class="n"><span class="bright">StyleSettings</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span class="n"><span class="bright">styleSettings</span></span><span class="bright"> </span><span class="n"><span class="bright">READ</span></span><span class="bright"> </span><span class="n"><span class="bright">styleSettings</span></span><span class="bright"> </span><span class="n"><span class="bright">CONSTANT</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">Q_PROPERTY</span><span class="p">(</span><span class="n">ToolBarStyle</span> <span class="n">mainToolBarStyle</span> <span class="n">READ</span> <span class="n">mainToolBarStyle</span> <span class="n">WRITE</span> <span class="n">setMainToolBarStyle</span> <span class="n">NOTIFY</span> <span class="n">mainToolBarStyleChanged</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Please have the space before the * and not after to follow the style of that file (see the Q_PROPERTY just above).</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24917#inline-140777">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcmstyle.h:66</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">iconsOnButton</span>s</span><span class="p">()</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">void</span> <span style="color: #004012">setIconsOnButtons</span><span class="p">(</span><span style="color: #aa4000">bool</span> <span class="n">enable</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">Q_SIGNAL</span> <span style="color: #aa4000">void</span> <span style="color: #004012">iconsOnButtonsChanged</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">bool</span> <span style="color: #004012">iconsInMenus</span><span class="p">()</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">void</span> <span style="color: #004012">setIconsInMenus</span><span class="p">(</span><span style="color: #aa4000">bool</span> <span class="n">enable</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">Q_SIGNAL</span> <span style="color: #aa4000">void</span> <span style="color: #004012">iconsInMenusChanged</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span class="n"><span class="bright">StyleSettings</span></span><span class="bright"></span><span style="color: #aa2211"><span class="bright">*</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">styleSetting</span>s</span><span class="p">()</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">ditto</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24917">https://phabricator.kde.org/D24917</a></div></div><br /><div><strong>To: </strong>crossi, ervin, mart, bport, Plasma<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>