<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24905">View Revision</a></tr></table><br /><div><div><p>I think all of thise <tt style="background: #ebebeb; font-size: 13px;">breaks</tt> in loops must be <tt style="background: #ebebeb; font-size: 13px;">continue</tt>s?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24905#inline-140591">View Inline</a><span style="color: #4b4d51; font-weight: bold;">networkmodel.cpp:457</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">item</span><span style="color: #aa2211">-></span><span class="n">itemType</span><span class="p">()</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">=</span>=</span> <span class="n">NetworkModelItem</span><span style="color: #aa2211">::</span><span class="n">AvailableConnection</span><span class="p">)<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">item</span><span style="color: #aa2211">-></span><span class="n">itemType</span><span class="p">()</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">!</span>=</span> <span class="n">NetworkModelItem</span><span style="color: #aa2211">::</span><span class="n">AvailableConnection</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">break</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Shouldn't this be a <tt style="background: #ebebeb; font-size: 13px;">continue</tt>?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24905#inline-140594">View Inline</a><span style="color: #4b4d51; font-weight: bold;">networkmodel.cpp:843</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">        <span class="bright">    </span><span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">dev</span><span style="color: #aa2211">-></span><span class="n">type</span><span class="p">()</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">=</span>=</span> <span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Device</span><span style="color: #aa2211">::</span><span class="n">Modem</span><span class="p">)<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">dev</span><span style="color: #aa2211">-></span><span class="n">type</span><span class="p">()</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">!</span>=</span> <span class="n">NetworkManager</span><span style="color: #aa2211">::</span><span class="n">Device</span><span style="color: #aa2211">::</span><span class="n">Modem</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">break</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">continue</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R116 Plasma Network Management Applet</div></div></div><br /><div><strong>BRANCH</strong><div><div>returnearly</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24905">https://phabricator.kde.org/D24905</a></div></div><br /><div><strong>To: </strong>nicolasfella, jgrulich<br /><strong>Cc: </strong>broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>