<table><tr><td style="">ngraham created this revision.<br />ngraham added reviewers: apol, Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />ngraham requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24677">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Because this script copies things to /, it needs to be run with <tt style="background: #ebebeb; font-size: 13px;">sudo</tt>. But two of the<br />
copy operations also copy things to your home directory, and if you <tt style="background: #ebebeb; font-size: 13px;">sudo</tt> the whole<br />
script, this results in those files being copied with root ownership, which can cause<br />
problems later.</p>

<p>This patch prepends <tt style="background: #ebebeb; font-size: 13px;">sudo</tt> to just the copy operations that need it so that the ones<br />
that don't aren't run with inappropriately elevated permissions.</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Run <tt style="background: #ebebeb; font-size: 13px;">~/kde/build/plasma-workspace/login-sessions/install-sessions.sh</tt></li>
<li class="remarkup-list-item">Get prompted for the root password</li>
<li class="remarkup-list-item">Enter it</li>
<li class="remarkup-list-item">See that <tt style="background: #ebebeb; font-size: 13px;">plasma-dev-prefix.sh</tt> and <tt style="background: #ebebeb; font-size: 13px;">startplasma-dev.sh</tt> in <tt style="background: #ebebeb; font-size: 13px;">~/kde/usr/lib64/libexec/</tt> have user ownership, not root ownership</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>BRANCH</strong><div><div>moar-sudo (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24677">https://phabricator.kde.org/D24677</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>login-sessions/install-sessions.sh.cmake</div></div></div><br /><div><strong>To: </strong>ngraham, apol, Plasma<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>