<table><tr><td style="">ervin requested changes to this revision.<br />ervin added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24520">View Revision</a></tr></table><br /><div><div><p>Overall this doesn't look like the proper fix to me. A setter should not do anything if we pass the current value to it. From your description it seems to indicate that a call to setTheme is missing in some situations, I think it'd lead to a better fix if the exact condition when this happens is determined and then the extra setTheme call inserted just then. Changing a setter semantic to get a side-effect looks wrong to me.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24520#inline-138683">View Inline</a><span style="color: #4b4d51; font-weight: bold;">previewwidget.h:34</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">Q_PROPERTY</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">currentIndex</span> <span class="n">READ</span> <span class="n">currentIndex</span> <span class="n">WRITE</span> <span class="n">setCurrentIndex</span> <span class="n">NOTIFY</span> <span class="n">currentIndexChanged</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">Q_PROPERTY</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">currentSize</span> <span class="bright"></span><span class="n"><span class="bright">READ</span></span><span class="bright"> </span><span class="n"><span class="bright">currentSize</span></span><span class="bright"> </span><span class="n">WRITE</span> <span class="n">setCurrentSize<span class="bright"></span></span><span class="bright"> </span><span class="n"><span class="bright">NOTIFY</span></span><span class="bright"> </span><span class="n"><span class="bright">currentSizeChanged</span></span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">Q_PROPERTY</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">currentSize</span> <span class="n">WRITE</span> <span class="n">setCurrentSize</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'd keep it as is for the reasons I mentioned in another patch: avoid write only properties, it's really annoying on the QML side.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24520">https://phabricator.kde.org/D24520</a></div></div><br /><div><strong>To: </strong>bport, Plasma, mart, ervin, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart<br /></div>