<table><tr><td style="">alexde added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24379">View Revision</a></tr></table><br /><div><div><p>As this it not in the scope of this patch, those values look suspicious to me too:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">switch(model.battery.type) {
case 3: return i18n("Internal battery")
case 2: return i18n("UPS battery")
case 9: return i18n("Monitor battery")
case 4: return i18n("Mouse battery")
case 5: return i18n("Keyboard battery")
case 1: return i18n("PDA battery")
case 7: return i18n("Phone battery")
default: return i18n("Unknown battery")</pre></div>
<p>Is there a special reason for the weired order? Is it correct that case 0 and 6 are missing and default to unknown? Maybe (I haven't looked deeper into it) this needs another patch.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24379#inline-137963">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:104</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">switch</span><span class="p">(</span><span style="color: #004012">value</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">case</span> <span style="color: #601200">0</span><span style="color: #aa2211">:</span> <span style="color: #aa4000">return</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Unknown <span class="bright">T</span>echnology"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">case</span> <span style="color: #601200">1</span><span style="color: #aa2211">:</span> <span style="color: #aa4000">return</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Lithium <span class="bright">I</span>on"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">case</span> <span style="color: #601200">0</span><span style="color: #aa2211">:</span> <span style="color: #aa4000">return</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Unknown <span class="bright">t</span>echnology"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">case</span> <span style="color: #601200">1</span><span style="color: #aa2211">:</span> <span style="color: #aa4000">return</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Lithium <span class="bright">i</span>on"</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Wouldn't it be better to define 0 as a default value?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24379#inline-137964">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:110</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">case</span> <span class="bright"></span><span style="color: #601200"><span class="bright">5</span></span><span style="color: #aa2211">:</span> <span style="color: #aa4000">return</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Lead Acid</span>"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">case</span> <span style="color: #601200">6</span><span style="color: #aa2211">:</span> <span style="color: #aa4000">return</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Nickel <span class="bright">M</span>etal <span class="bright">H</span>ydride"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">case</span> <span class="bright"></span><span style="color: #601200"><span class="bright">6</span></span><span style="color: #aa2211">:</span> <span style="color: #aa4000">return</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Nickel cadmium</span>"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">case</span> <span style="color: #601200">6</span><span style="color: #aa2211">:</span> <span style="color: #aa4000">return</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Nickel <span class="bright">m</span>etal <span class="bright">h</span>ydride"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Now you have two times the case 6</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24379">https://phabricator.kde.org/D24379</a></div></div><br /><div><strong>To: </strong>meven, ngraham, ltoscano<br /><strong>Cc: </strong>alexde, plasma-devel, ltoscano, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>