<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24011">View Revision</a></tr></table><br /><div><div><p>I would remove the big text block from the form layout, since this makes it look off-center. Also it needs a bigger margin below it. See also the following inline comments:</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24011#inline-137834">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:68</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">modeOptions</span><span class="p">.</span><span style="color: #004012">append</span><span class="p">({</span><span style="color: #aa4000">text:</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Detailed System Information"</span><span class="p">),</span> <span style="color: #aa4000">value:</span> <span style="color: #004012">UserFeedback</span><span class="p">.</span><span style="color: #004012">Provider</span><span class="p">.</span><span style="color: #004012">DetailedSystemInformation</span><span class="p">})</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">modeOptions</span><span class="p">.</span><span style="color: #004012">append</span><span class="p">({</span><span style="color: #aa4000">text:</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"Detailed Usage Information"</span><span class="p">),</span> <span style="color: #aa4000">value:</span> <span style="color: #004012">UserFeedback</span><span class="p">.</span><span style="color: #004012">Provider</span><span class="p">.</span><span style="color: #004012">DetailedUsageStatistics</span><span class="p">})</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">These strings still need to be re-worded, and possibly collapsed, and possible the whole UI needs to be re-thought. What if I want to submit detailed system information but only basic usage information? Maybe we need two combo boxes, one for system info and one for usage info.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24011#inline-137833">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:89</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">QQC2</span><span class="p">.</span><span style="color: #004012">Label</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.maximumWidth:</span> <span style="color: #004012">root</span><span class="p">.</span><span style="color: #004012">width</span> <span style="color: #aa2211">*</span> <span style="color: #601200">0.5</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This label never shows up for me, no matter which entry is selected in the combo box.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24011#inline-136284">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ngraham</span> wrote in <span style="color: #4b4d51; font-weight: bold;">main.qml:41</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><ol class="remarkup-list">
<li class="remarkup-list-item">Since this is no longer just about Plasma, maybe the first sentence should say, "We make software for you".</li>
</ol>
<ol class="remarkup-list" start="2">
<li class="remarkup-list-item">Use kuit formatting for newlines: <tt style="background: #ebebeb; font-size: 13px;">xi18nc("@info", "Line 1<nl/>Line 2<nl/>Line 3<nl/>etc.");</tt></li>
</ol></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">#1 isn't done yet (it still talks about Plasma, not KDE software more generally)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24011">https://phabricator.kde.org/D24011</a></div></div><br /><div><strong>To: </strong>apol, Plasma, vkrause, ngraham<br /><strong>Cc: </strong>aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>