<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24070">View Revision</a></tr></table><br /><div><div><p>From what I can tell, the problem with  <tt style="background: #ebebeb; font-size: 13px;">remainingTime</tt> being 0 sometimes is a pre-existing bug that the current code is hiding fairly well by not showing the string that uses that value when the time is 0. We should fix that later, but for now what we should do is replicate the hiding logic for all cases in the new style too (see inline comment). Than I think this can go in, pending <a href="https://phabricator.kde.org/p/broulik/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@broulik</a>'s approval.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24070#inline-137381">View Inline</a><span style="color: #4b4d51; font-weight: bold;">batterymonitor.qml:93</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">pmSource</span><span class="p">.</span><span style="color: #004012">data</span><span class="p">[</span><span style="color: #766510">"AC Adapter"</span><span class="p">]</span> <span style="color: #aa2211">&&</span> <span style="color: #004012">pmSource</span><span class="p">.</span><span style="color: #004012">data</span><span class="p">[</span><span style="color: #766510">"AC Adapter"</span><span class="p">][</span><span style="color: #766510">"Plugged in"</span><span class="p">])</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">return</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"%1 until fully charged"</span><span class="p">,</span> <span style="color: #004012">KCoreAddons</span><span class="p">.</span><span style="color: #004012">Format</span><span class="p">.</span><span style="color: #004012">formatDuration</span><span class="p">(</span><span style="color: #004012">remainingTime</span><span class="p">,</span> <span style="color: #004012">KCoreAddons</span><span class="p">.</span><span style="color: #004012">FormatTypes</span><span class="p">.</span><span style="color: #004012">HideSeconds</span><span class="p">))</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This block also needs` if (remainingTime > 0) {` like the one below it</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24070">https://phabricator.kde.org/D24070</a></div></div><br /><div><strong>To: </strong>mthw, ngraham, VDG, Plasma, broulik, ndavis<br /><strong>Cc: </strong>ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>