<table><tr><td style="">fvogt added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24194">View Revision</a></tr></table><br /><div><div><p>AFAICT it doesn't reload the mpris state in the content-script immediately when settings change, can that be implemented?</p>
<p>IMO the blacklist should be more than the domain, it should test the same conditions as CORS, so protocol, domain and port.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24194#inline-137189">View Inline</a><span style="color: #4b4d51; font-weight: bold;">action_popup.js:20</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Gets the URL of the currently viewed tab</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">static</span> <span style="color: #004012">getCurrentUrl</span><span class="p">()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span style="color: #aa4000">new</span> <span style="color: #304a96">Promise</span><span class="p">((</span><span style="color: #004012">resolve</span><span class="p">,</span> <span style="color: #004012">reject</span><span class="p">)</span> <span style="color: #aa2211">=></span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">getCurrentTabUrl()</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24194#inline-137190">View Inline</a><span style="color: #4b4d51; font-weight: bold;">action_popup.js:42</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// Gets the URLs of the currently viewed tab including all of its iframes</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">static</span> <span style="color: #004012">getCurrentUrls</span><span class="p">()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span style="color: #aa4000">new</span> <span style="color: #304a96">Promise</span><span class="p">((</span><span style="color: #004012">resolve</span><span class="p">,</span> <span style="color: #004012">reject</span><span class="p">)</span> <span style="color: #aa2211">=></span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Currently the function name implies that it returns all tabs, so maybe rename to <tt style="background: #ebebeb; font-size: 13px;">getCurrentTabFramesUrls()</tt> (or better)?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24194#inline-137182">View Inline</a><span style="color: #4b4d51; font-weight: bold;">action_popup.js:46</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">allFrames</span><span style="color: #aa2211">:</span> <span style="color: #000a65">true</span><span class="p">,</span> <span style="color: #74777d">// so we also catch iframe videos</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">code</span><span style="color: #aa2211">:</span> <span style="color: #766510">`window.location.href`</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">},</span> <span class="p">(</span><span style="color: #004012">result</span><span class="p">)</span> <span style="color: #aa2211">=></span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Maybe <tt style="background: #ebebeb; font-size: 13px;">runAt: "document_start"</tt> to speed it up a bit? I'm not sure about the implications.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24194#inline-137186">View Inline</a><span style="color: #4b4d51; font-weight: bold;">action_popup.js:62</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span style="color: #aa4000">new</span> <span style="color: #304a96">Promise</span><span class="p">((</span><span style="color: #004012">resolve</span><span class="p">,</span> <span style="color: #004012">reject</span><span class="p">)</span> <span style="color: #aa2211">=></span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">Promise</span><span class="p">.</span><span style="color: #004012">all</span><span class="p">([</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Whitespace?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24194#inline-137188">View Inline</a><span style="color: #4b4d51; font-weight: bold;">action_popup.js:118</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">set</span><span class="p">(</span><span style="color: #004012">domain</span><span class="p">,</span> <span style="color: #004012">block</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span style="color: #aa4000">this</span><span class="p">.</span><span style="color: #004012">get</span><span class="p">().</span><span style="color: #004012">then</span><span class="p">((</span><span style="color: #004012">blockInfo</span><span class="p">)</span> <span style="color: #aa2211">=></span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Currently calling <tt style="background: #ebebeb; font-size: 13px;">set(domain, false);</tt> twice has a different result from <tt style="background: #ebebeb; font-size: 13px;">set(domain, false);</tt> once, so maybe split into <tt style="background: #ebebeb; font-size: 13px;">whitelist(domain)</tt> and <tt style="background: #ebebeb; font-size: 13px;">blacklist(domain)</tt>)?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24194#inline-137187">View Inline</a><span style="color: #4b4d51; font-weight: bold;">action_popup.js:120</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">return</span> <span style="color: #aa4000">this</span><span class="p">.</span><span style="color: #004012">get</span><span class="p">().</span><span style="color: #004012">then</span><span class="p">((</span><span style="color: #004012">blockInfo</span><span class="p">)</span> <span style="color: #aa2211">=></span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">let</span> <span style="color: #004012">whitelist</span> <span style="color: #aa2211">=</span> <span style="color: #004012">blockInfo</span><span class="p">.</span><span style="color: #004012">mprisSettings</span><span class="p">.</span><span style="color: #004012">whitelistedDomains</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Whitespace?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24194#inline-137192">View Inline</a><span style="color: #4b4d51; font-weight: bold;">content-script.js:68</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #004012">mpris</span><span class="p">.</span><span style="color: #004012">enabled</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">const</span> <span style="color: #004012">domain</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">window</span><span class="p">.</span><span style="color: #004012">location</span><span class="p">.</span><span style="color: #004012">hostname</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is this guaranteed to be identical to <tt style="background: #ebebeb; font-size: 13px;">new URL(window.location.href).hostname</tt> as used in utils?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24194#inline-137191">View Inline</a><span style="color: #4b4d51; font-weight: bold;">content-script.js:70</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">const</span> <span style="color: #004012">whitelist</span> <span style="color: #aa2211">=</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">mpris</span><span class="p">.</span><span style="color: #004012">whitelistedDomains</span> <span style="color: #aa2211">||</span> <span class="p">[];</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #304a96">const</span> <span style="color: #004012">blacklist</span> <span style="color: #aa2211">=</span> <span style="color: #004012">items</span><span class="p">.</span><span style="color: #004012">mpris</span><span class="p">.</span><span style="color: #004012">blacklistedDomains</span> <span style="color: #aa2211">||</span> <span class="p">[];</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use <tt style="background: #ebebeb; font-size: 13px;">mpris.</tt> instead of <tt style="background: #ebebeb; font-size: 13px;">items.mpris</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24194">https://phabricator.kde.org/D24194</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG, fvogt, ognarb<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>