<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24194">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>AFAICT it doesn't reload the mpris state in the content-script immediately when settings change, can that be implemented?</p></blockquote>
<p>First we need <a href="https://phabricator.kde.org/D24203" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D24203</a>.<br />
It might be tricky to properly unload e.g. the media sessions stuff, but I can look into this.<br />
Actually, I wanted to implement "live" settings changes for the other settings (like breeze scroll bars and what not) in a later step, too, for which <a href="https://phabricator.kde.org/D24203" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D24203</a> is a prerequisite.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24194#inline-137189">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fvogt</span> wrote in <span style="color: #4b4d51; font-weight: bold;">action_popup.js:20</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">getCurrentTabUrl()</tt></p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">The class is named <tt style="background: #ebebeb; font-size: 13px;">TabUtils</tt> but I can change the method if you want..</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24194#inline-137182">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fvogt</span> wrote in <span style="color: #4b4d51; font-weight: bold;">action_popup.js:46</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Maybe <tt style="background: #ebebeb; font-size: 13px;">runAt: "document_start"</tt> to speed it up a bit? I'm not sure about the implications.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Don't think this will change much, given it is only executed when you click the toolbar button, at which point the page is probably already loaded, but I'll give it a try</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24194#inline-137186">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fvogt</span> wrote in <span style="color: #4b4d51; font-weight: bold;">action_popup.js:62</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Whitespace?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Intentional, for a bit of visual grouping</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24194#inline-137188">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fvogt</span> wrote in <span style="color: #4b4d51; font-weight: bold;">action_popup.js:118</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Currently calling <tt style="background: #ebebeb; font-size: 13px;">set(domain, false);</tt> twice has a different result from <tt style="background: #ebebeb; font-size: 13px;">set(domain, false);</tt> once, so maybe split into <tt style="background: #ebebeb; font-size: 13px;">whitelist(domain)</tt> and <tt style="background: #ebebeb; font-size: 13px;">blacklist(domain)</tt>)?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Imho the caller shouldn't have to care about whether it needs to be whitelisted or removed from the blacklist. The whitelist is only so that the user can opt-in to websites which we by default blacklist.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24194#inline-137192">View Inline</a><span style="color: #4b4d51; font-weight: bold;">fvogt</span> wrote in <span style="color: #4b4d51; font-weight: bold;">content-script.js:68</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Is this guaranteed to be identical to <tt style="background: #ebebeb; font-size: 13px;">new URL(window.location.href).hostname</tt> as used in utils?</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Good question, no idea, probably. :)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24194">https://phabricator.kde.org/D24194</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG, fvogt, ognarb<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>