<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24011">View Revision</a></tr></table><br /><div><div><p>Thanks, looking better.</p>
<p>I don't see explanatory text below the combobox yet; looks like that part isn't quite working.</p>
<p>Also, suppose I want to contribute both usage and system information, how do I do that? The wording in the combobox implies that I can only contribute one or the other. If there are multiple pieces of information that it would make sense to send, then a combobox isn't the right control and we'll need to use radio buttons or checkboxes--or else we'll need to re-word the options so that they reveal the full set of what will be included.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24011#inline-136286">View Inline</a><span style="color: #4b4d51; font-weight: bold;">feedback.cpp:41</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">setAboutData</span><span class="p">(</span><span style="color: #aa4000">new</span> <span class="n">KAboutData</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"kcm_feedback"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Configure User Feedback Settings"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"1.0"</span><span class="p">),</span> <span class="n">QString</span><span class="p">(),</span> <span class="n">KAboutLicense</span><span style="color: #aa2211">::</span><span class="n">LGPL</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Title should be the same as the name i.e. "User Feedback"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24011#inline-136287">View Inline</a><span style="color: #4b4d51; font-weight: bold;">feedback.cpp:42</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Configure User Feedback Settings"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"1.0"</span><span class="p">),</span> <span class="n">QString</span><span class="p">(),</span> <span class="n">KAboutLicense</span><span style="color: #aa2211">::</span><span class="n">LGPL</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Description should be "Configure user feedback settings"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24011#inline-136288">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kcm_feedback.desktop:14</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Name=User Feedback
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Add <tt style="background: #ebebeb; font-size: 13px;">Comment=Configure user feedback settings</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24011#inline-136289">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:23</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.</span><span style="color: #004012">Layouts</span> <span style="color: #601200">1.1</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.</span><span style="color: #004012">Controls</span> <span style="color: #601200">2.3</span> <span style="color: #004012">as</span> <span style="color: #004012">QtControls</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">org</span><span class="p">.</span><span style="color: #004012">kde</span><span class="p">.</span><span style="color: #004012">kirigami</span> <span style="color: #601200">2.6</span> <span style="color: #004012">as</span> <span style="color: #004012">Kirigami</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"as QQC2"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24011#inline-136284">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:41</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">wrapMode:</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">WordWrap</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">i18n</span><span class="p">(</span><span style="color: #766510">"We make Plasma for you. You can help us improve it by contributing information on how you use it. This allows us to focus on things that matter to you.\n\nContributing usage information is optional and entirely anonymous. It will not associate the data with any kind of unique identifier, and will never track the documents you open, the websites you visit, or any other kind of personal information.\n\nYou can read more about our policy in the following link."</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><ol class="remarkup-list">
<li class="remarkup-list-item">Since this is no longer just about Plasma, maybe the first sentence should say, "We make software for you".</li>
</ol>
<ol class="remarkup-list" start="2">
<li class="remarkup-list-item">Use kuit formatting for newlines: <tt style="background: #ebebeb; font-size: 13px;">xi18nc("@info", "Line 1<nl/>Line 2<nl/>Line 3<nl/>etc.");</tt></li>
</ol></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24011">https://phabricator.kde.org/D24011</a></div></div><br /><div><strong>To: </strong>apol, Plasma, vkrause, ngraham<br /><strong>Cc: </strong>aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>