<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D24049">View Revision</a></tr></table><br /><div><div><p>In general +1</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24049#inline-136132">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SidebarMode.cpp:581</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">toolTipManager</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">ToolTipManager</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">searchModel</span><span class="p">,</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">quickWidget</span><span class="p">,</span> <span style="color: #304a96">false</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">subCategoryToolTipManager</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">ToolTipManager</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">subCategoryModel</span><span class="p">,</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">quickWidget</span><span class="p">,</span> <span style="color: #304a96">false</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is there a strong reason to move these around?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D24049#inline-136133">View Inline</a><span style="color: #4b4d51; font-weight: bold;">tooltipmanager.h:48</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #74777d">    */</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">explicit</span> <span class="n">ToolTipManager</span><span class="p">(</span><span class="n">QAbstractItemModel</span> <span style="color: #aa2211">*</span><span class="n">model</span><span class="p">,</span> <span class="n">QWidget</span><span style="color: #aa2211">*</span> <span class="n">parent</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">explicit</span> <span class="n">ToolTipManager</span><span class="p">(</span><span class="n">QAbstractItemModel</span> <span style="color: #aa2211">*</span><span class="n">model</span><span class="p">,</span> <span class="n">QWidget</span><span style="color: #aa2211">*</span> <span class="n">parent<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> </span><span class="n"><span class="bright">centered</span></span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa2211">~</span><span class="n">ToolTipManager</span><span class="p">()</span> <span class="n">override</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Use an Enum here instead of a bool to improve readability. See for example <a href="https://codereview.stackexchange.com/questions/11300/boolean-enums-improved-clarity-or-just-overkill" class="remarkup-link" target="_blank" rel="noreferrer">https://codereview.stackexchange.com/questions/11300/boolean-enums-improved-clarity-or-just-overkill</a></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R124 System Settings</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D24049">https://phabricator.kde.org/D24049</a></div></div><br /><div><strong>To: </strong>tienisto, VDG, ngraham, GB_2<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>