<table><tr><td style="">meven added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12827">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D12827#528767" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D12827#528767</a>, <a href="https://phabricator.kde.org/p/chrisx/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@chrisx</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p><a href="https://phabricator.kde.org/p/meven/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@meven</a> Sorry I've totally forgotten about your suggestions when I was updating the patch...<br />
I have renamed <tt style="background: #ebebeb; font-size: 13px;">DetailsDlg</tt> to <tt style="background: #ebebeb; font-size: 13px;">ProcessDetailsDialog</tt>. But I've got some minor issues with code indentation. I have tried out <tt style="background: #ebebeb; font-size: 13px;">uncrustify-kf5</tt> (which didn't even work out-of-box. Instead of formatting the files in-place, it produced <tt style="background: #ebebeb; font-size: 13px;">*.uncrustify</tt> files instead. I have uncrustify 0.69, and I worked around the issue by adding <tt style="background: #ebebeb; font-size: 13px;">--replace</tt> to the arguments for uncrystify in <tt style="background: #ebebeb; font-size: 13px;">uncrustify-kf5</tt>). But the script produces way too many changes in some files I changed. One of those files is <tt style="background: #ebebeb; font-size: 13px;">processes_linux_p.cpp</tt>, which uses both spaces and tabs for indentation. So at this moment I've only committed some of the indentation changes.<br />
Any further help with pushing this patch forward would be greatly appreciated.</p></div>
</blockquote>
<p>Sorry I should have mentioned and better explained.<br />
The uncrustify-kf5 is located kde-dev-scripts and depends on uncrustify.<br />
To use it only for a few files a workaround is to run it git add only the files you mean to commit and then git checkout the files you don't want to chaneg.<br />
If too many lines are concerned better skip this here then.</p>
<p>Please note I am no ksysguard maintainer, and the Ksysguard app is going through a UI renew.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R111 KSysguard Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12827">https://phabricator.kde.org/D12827</a></div></div><br /><div><strong>To: </strong>chrisx, broulik, davidedmundson, mart<br /><strong>Cc: </strong>meven, garywang, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>