<table><tr><td style="">ngraham added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23712">View Revision</a></tr></table><br /><div><div><p>Some general comments:</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">Try to use QML Layouts as much as possible; for the most part, everything should be in a layout.</li>
<li class="remarkup-list-item">Anytime you're tempted to create a <tt style="background: #ebebeb; font-size: 13px;">Rectangle</tt> with <tt style="background: #ebebeb; font-size: 13px;">color: "transparent"</tt>, don't. Just use an <tt style="background: #ebebeb; font-size: 13px;">Item</tt> instead. But you may not even need to do this if you use Layouts more.</li>
</ul>
<p>Idea: since the sidebar is now nice and wide, don't put the icon name inside the squeezed <tt style="background: #ebebeb; font-size: 13px;">FormLayout</tt> below the icon montage. Instead, make it a header above the icon montage. Here's a patch to your patch that will implement these and other proposed changes: <a href="https://invent.kde.org/snippets/443" class="remarkup-link" target="_blank" rel="noreferrer">https://invent.kde.org/snippets/443</a>. It will look like this:</p>
<p><a href="https://phabricator.kde.org/F7341810" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7341810: Screenshot_20190911_163718.png</a></p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23712#inline-135032">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Preview.qml:78</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">anchors.fill:</span> <span style="color: #004012">parent</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">spacing:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">units</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">gridUnit</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">/</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">2</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">columns:</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">1</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">Rectangle</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">A GridLayout with one column is just a ColumnLayout; use that instead</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23712#inline-135031">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Preview.qml:135</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">QQC2</span><span class="p">.</span><span style="color: #004012">ToolButton</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">visible:</span> <span style="color: #aa2211">!</span><span style="color: #004012">iconPreview</span><span class="p">.</span><span style="color: #004012">screenshotting</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Center this button horizontally</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23712#inline-135029">View Inline</a><span style="color: #4b4d51; font-weight: bold;">Tools.qml:36</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="p"><span class="bright">}</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span class="p"><span class="bright">}</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">tools:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">RowLayout</span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">anchors.fill:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">parent</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #aa4000"><span class="bright">anchors.leftMargin:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">Kirigami</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">Units</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">smallSpacing</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"> </span><span style="color: #aa4000"><span class="bright">anchors.verticalCenter:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">parent</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">verticalCenter</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Set the same thing for the right margin too</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R118 Plasma SDK</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23712">https://phabricator.kde.org/D23712</a></div></div><br /><div><strong>To: </strong>cblack, VDG, ngraham<br /><strong>Cc: </strong>GB_2, trickyricky26, davidre, ndavis, filipf, davidedmundson, ngraham, plasma-devel, VDG, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>