<table><tr><td style="">davidedmundson accepted this revision.<br />davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23518">View Revision</a></tr></table><br /><div><div><p>Yeah, but I /really really really/ don't like surprise upgrade behaviour that you get this patch and suddenly your incognito windows are being publicly broadcast everywhere. It could lead to something quite bad.</p>

<p>The whole situation sucks, but I don't think we have a choice.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23518#inline-132811">View Inline</a><span style="color: #4b4d51; font-weight: bold;">extension-utils.js:28</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">let</span> <span style="color: #004012">firefoxVersionMatch</span> <span style="color: #aa2211">=</span> <span style="color: #004012">navigator</span><span class="p">.</span><span style="color: #004012">userAgent</span><span class="p">.</span><span style="color: #004012">match</span><span class="p">(</span><span style="color: #bb6688">/Firefox\/(\d+)/</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span style="color: #aa4000">let</span> <span style="color: #004012">firefoxVersion</span> <span style="color: #aa2211">=</span> <span style="color: #004012">firefoxVersionMatch</span> <span style="color: #aa2211">?</span> <span style="color: #304a96">Number</span><span class="p">(</span><span style="color: #004012">firefoxVersionMatch</span><span class="p">[</span><span style="color: #601200">1</span><span class="p">])</span> <span style="color: #aa2211">:</span> <span style="color: #000a65">NaN</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">may as well keep this?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23518">https://phabricator.kde.org/D23518</a></div></div><br /><div><strong>To: </strong>broulik, Plasma, fvogt, davidbekham, ngraham, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>