<table><tr><td style="">apol added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23502">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23502#inline-132751">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActionToolBar.qml:183</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                    <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span style="color: #aa4000">return</span> <span style="color: #004012">result</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span class="p">}</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span style="color: #aa4000">itemDelegate:</span> <span style="color: #004012">ActionMenuItem</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">          <span style="color: #aa4000">visible:</span> <span style="color: #004012">actionsLayout</span><span class="p">.</span><span style="color: #004012">findIndex</span><span class="p">(</span><span style="color: #004012">actionsLayout</span><span class="p">.</span><span style="color: #004012">overflowSet</span><span class="p">,</span> <span style="color: #aa4000">function</span><span class="p">(</span><span style="color: #004012">act</span><span class="p">)</span> <span class="p">{</span><span style="color: #aa4000">return</span> <span style="color: #004012">act</span> <span style="color: #aa2211">===</span> <span style="color: #004012">ourAction</span><span class="p">})</span> <span style="color: #aa2211">></span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span> <span style="color: #aa2211">&&</span>  <span class="p">(</span> <span style="color: #004012">ourAction</span><span class="p">.</span><span style="color: #004012">hasOwnProperty</span><span class="p">(</span><span style="color: #766510">"visible"</span><span class="p">)</span> <span style="color: #aa2211">?</span> <span style="color: #004012">ourAction</span><span class="p">.</span><span style="color: #004012">visible</span> <span style="color: #aa2211">===</span> <span style="color: #000a65">undefined</span> <span style="color: #aa2211">||</span> <span style="color: #aa4000">ourAction.visible :</span> <span style="color: #aa2211">!</span><span style="color: #004012">ourAction</span><span class="p">.</span><span style="color: #004012">hasOwnProperty</span><span class="p">(</span><span style="color: #766510">"visible"</span><span class="p">))</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">it could be <tt style="background: #ebebeb; font-size: 13px;">children: [].concat(root.actions).concat(hiddenActions);</tt> no?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23502#inline-132752">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ActionToolBar.qml:207</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                    <span class="bright"></span><span style="color: #aa4000"><span class="bright">onObjectAdded:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">object</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">create</span></span><span class="bright"></span><span class="p"><span class="bright">()</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                    <span style="color: #aa4000">onObjectRemoved:</span> <span style="color: #004012">object</span><span class="p">.</span><span style="color: #004012">remove</span><span class="p">()</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span class="bright"></span><span style="color: #aa4000"><span class="bright">return</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">ourAction</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">hasOwnProperty</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"visible"</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">ourAction</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">visible</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">===</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">undefined</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">ourAction.visible :</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">true</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">since it's boolean, you can do:<br />
<tt style="background: #ebebeb; font-size: 13px;">visible: !actionsLayout.isActionVisible(ourAction) && (ourAction.visible === undefined || ourAction.visible)</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R169 Kirigami</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23502">https://phabricator.kde.org/D23502</a></div></div><br /><div><strong>To: </strong>ahiemstra, Kirigami, mart<br /><strong>Cc: </strong>apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, davidedmundson, mart, hein<br /></div>