<table><tr><td style="">mak added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23306">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D23306#515577" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">D23306#515577</a>, <a href="https://phabricator.kde.org/p/ngraham/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@ngraham</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>Adjust according to review comments</p></div>
</blockquote>

<p>This will work. I would change <tt style="background: #ebebeb; font-size: 13px;"><name>System Settings</name></tt> to <tt style="background: #ebebeb; font-size: 13px;"><name> KDE System Settings</name></tt> or <tt style="background: #ebebeb; font-size: 13px;"><name>Plasma System Settings</name></tt>, just like GNOME sets a name like "GNOME Videos" instead of "Videos" in their metadata. Otherwise this name will confuse users of GNOME, I guess.<br />
You'll also highly likely want to set <tt style="background: #ebebeb; font-size: 13px;">compulsory_for_desktop</tt> ( <a href="https://www.freedesktop.org/software/appstream/docs/chap-CollectionData.html#tag-ct-compulsory_for_desktop" class="remarkup-link" target="_blank" rel="noreferrer">https://www.freedesktop.org/software/appstream/docs/chap-CollectionData.html#tag-ct-compulsory_for_desktop</a> ) to prevent this app to be removable on Plasma.<br />
So adding</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><compulsory_for_desktop>KDE</compulsory_for_desktop>
<compulsory_for_desktop>Plasma</compulsory_for_desktop></pre></div>

<p>will do the trick (AppStream recognizes "Plasma", but the desktop is actually known as "KDE" everywhere in Freedesktop, so just using "KDE" would probably be sufficient and compatible with everything. Having "Plasma" as well won't hurt though)<br />
Ypu may want <a href="https://spdx.org/licenses/FSFAP.html" class="remarkup-link" target="_blank" rel="noreferrer">FSFAP</a> as <tt style="background: #ebebeb; font-size: 13px;">metadata_license</tt> as it's much shorter than CC0 and mixes well with GPL. However that's a personal choice and not required for anything. CC0 would work just fine.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R124 System Settings</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23306">https://phabricator.kde.org/D23306</a></div></div><br /><div><strong>To: </strong>ngraham, apol, mak, Plasma<br /><strong>Cc: </strong>kossebau, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>