<table><tr><td style="">meven added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D12827">View Revision</a></tr></table><br /><div><div><p>I quite like this feature <a href="https://phabricator.kde.org/p/chrisx/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@chrisx</a><br />
I hope you can still push it forward after all this time.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12827#inline-130953">View Inline</a><span style="color: #4b4d51; font-weight: bold;">DetailsDlg.cpp:1</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d">/*</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #74777d"> KSysGuard, the KDE System Guard</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Personally I would favor a class name with no abbreviation, here DetailsDialog, and here perhaps make it more explicit like ProcessDetailsDialog.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12827#inline-130951">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ksysguardprocesslist.cpp:205</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">renice</span><span style="color: #aa2211">-></span><span class="n">setShortcut</span><span class="p">(</span><span class="n">Qt</span><span style="color: #aa2211">::</span><span class="n">Key_F8</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">details</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QAction</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Process Details..."</span><span class="p">),</span> <span class="n">q</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">selectParent</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QAction</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Jump to Parent Process"</span><span class="p">),</span> <span class="n">q</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Indentation seems off.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D12827#inline-130952">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ksysguardprocesslist.cpp:1225</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QList</span><span style="color: #aa2211"><</span><span class="n">KSysGuard</span><span style="color: #aa2211">::</span><span class="n">Process</span> <span style="color: #aa2211">*></span> <span class="n">processes</span> <span style="color: #aa2211">=</span> <span class="n">selectedProcesses</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span><span class="p">(</span><span class="n">processes</span><span class="p">.</span><span class="n">size</span><span class="p">()</span><span style="color: #aa2211">!=</span><span style="color: #601200">1</span><span class="p">)</span><span style="color: #aa4000">return</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QPointer</span><span style="color: #aa2211"><</span><span class="n">DetailsDlg</span><span style="color: #aa2211">></span> <span class="n">detailsdlg</span><span style="color: #aa2211">=</span><span style="color: #aa4000">new</span> <span class="n">DetailsDlg</span><span class="p">(</span><span class="n">processes</span><span class="p">.</span><span class="n">first</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">pid</span><span class="p">(),</span><span class="n">processModel</span><span class="p">(),</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">mUi</span><span style="color: #aa2211">-></span><span class="n">treeView</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if (processes.size() != 1) {</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">return;</pre></div>
<p style="padding: 0; margin: 8px;">}<br />
You can try to use uncrustify-kf5 to (<a href="https://github.com/KDE/kde-dev-scripts/blob/master/uncrustify-kf5" class="remarkup-link" target="_blank" rel="noreferrer">https://github.com/KDE/kde-dev-scripts/blob/master/uncrustify-kf5</a>) to solve code style and indentation issues.<br />
It works on whole directories only, so you might want to use <tt style="background: #ebebeb; font-size: 13px;">uncrustify-kf5; git commit --amend --no-edit [files part you are adding/touching] ; git checkout .</tt></p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R111 KSysguard Library</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D12827">https://phabricator.kde.org/D12827</a></div></div><br /><div><strong>To: </strong>chrisx, broulik, davidedmundson<br /><strong>Cc: </strong>meven, garywang, broulik, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>