<table><tr><td style="">meven added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22012">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
          color: #6B748C;
          font-style: italic;
          margin: 4px 0 12px 0;
          padding: 8px 12px;
          background-color: #F8F9FC;">
<div style="font-style: normal;
          padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22012#512025" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: line-through;">D22012#512025</a>, <a href="https://phabricator.kde.org/p/davidedmundson/" style="
              border-color: #f1f7ff;
              color: #19558d;
              background-color: #f1f7ff;
                border: 1px solid transparent;
                border-radius: 3px;
                font-weight: bold;
                padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
          padding: 0;
          border: 0;
          color: rgb(107, 116, 140);"><p>It was first added in <a href="https://phabricator.kde.org/R119:2d5f289767ee7b7c54f8b55e8032d20ef7f092f4" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">2d5f289767ee7b7c54f8b55e8032d20ef7f092f4</a> with some pretty sparse docs, then copy pasted all over the place.</p>

<p>It does appear to be no longer needed.</p>

<p>I suspect <a href="https://codereview.qt-project.org/c/qt/qtbase/+/139775" class="remarkup-link" target="_blank" rel="noreferrer">https://codereview.qt-project.org/c/qt/qtbase/+/139775</a> fixes it which was back in 5.6</p>

<p>If we remove here, please can we also do</p>

<p>kcms/desktoptheme/kcm.cpp:    qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);<br />
 kcms/fonts/fonts.cpp:    qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);<br />
 kcms/lookandfeel/kcm.cpp:    qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);</p>

<p>in p-d</p></div>
</blockquote>

<p>Will do.</p>

<p>It is also present in other apps than kcms :</p>

<p>$ rg AA_DontCreateNativeWidgetSiblings<br />
systemsettings/sidebar/SidebarMode.cpp<br />
258:    qApp->setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);</p>

<p>spectacle/src/Main.cpp<br />
37:    app.setAttribute(Qt::AA_DontCreateNativeWidgetSiblings, true);</p>

<p>kdevelop/app/main.cpp<br />
348:    QCoreApplication::setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);</p>

<p>discover/discover/main.cpp<br />
97:    app.setAttribute(Qt::AA_DontCreateNativeWidgetSiblings);</p>

<p>I wonder if this can be removed there as well.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22012">https://phabricator.kde.org/D22012</a></div></div><br /><div><strong>To: </strong>meven, mart, Plasma, davidedmundson<br /><strong>Cc: </strong>davidedmundson, ngraham, mart, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>