<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, davidedmundson, fvogt.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23122">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Media Sessions API usage becomes more and more common, so it is quite nice to get proper album art. Also, calling into media session for play/pause when the website provides them is nicer than blatantly calling <tt style="background: #ebebeb; font-size: 13px;">pause()</tt> on the player item.<br />
It also isn't as invasive as the original implementation used to be since it doesn't manipulate the website DOM anymore.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>I've been using this forever without any hickups.<br />
I also couldn't reproduce the Bug 397684 at all and likely to have been caused by the HTML element we injected into the website throwing off some JS templating lib.</p>
<p>David I think said once that he could reproduce it or is running home assist, so can you check if it works for you still?</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23122">https://phabricator.kde.org/D23122</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>extension/_locales/en/messages.json<br />
extension/constants.js</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, davidedmundson, fvogt<br /><strong>Cc: </strong>plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>