<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, VDG, fvogt.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23126">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>This adds a tool bar icon for reporting extension status in lieu of the error notification.<br />
When the extension isn't supported or fails to start, the Plasma icon is crossed out. Especially when synced to a device without plasma-browser-integration, the error notification that used to show up can be annoying and misleading.<br />
When the extension crashes, an overlay is shown.<br />
Currently, the overlay is disabled when the extension is running properly, but additional controls such as sharing and media controls blacklist settings could be added to the browser action. This patch is mostly for the base infrastructure of such a toolbar icon.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Needs proper icon from VDG, cf. Bug 410821</p>
<p>Disabled icon<br />
<a href="https://phabricator.kde.org/F7235286" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7235286: Screenshot_20190813_155423.png</a><br />
Explanation for not working<br />
<a href="https://phabricator.kde.org/F7235285" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7235285: Screenshot_20190813_155400.png</a><br />
<a href="https://phabricator.kde.org/F7235287" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7235287: Screenshot_20190813_155453.png</a></p>
<p>Crashed icon<br />
<a href="https://phabricator.kde.org/F7235282" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7235282: Screenshot_20190811_220957.png</a><br />
Crashed explanation<br />
<a href="https://phabricator.kde.org/F7235288" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7235288: Screenshot_20190813_155517.png</a><br />
When the host crashes, you also get a DrKonqi dialog but don't think there's a way for us (other than matching the "Native host has exited" string) to tell whether it crashed (DrKonqi) or got disconnected for violating the communication protocol or just quit gracefully because of some other issue (No DrKonqi)</p>
<p>All working<br />
<a href="https://phabricator.kde.org/F7235297" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F7235297: Screenshot_20190813_155854.png</a><br />
Chrome always shows an extension icon which has a default context menu, on Firefox the icon hides completely in this case.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23126">https://phabricator.kde.org/D23126</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>extension/_locales/en/messages.json<br />
extension/action_popup.css<br />
extension/action_popup.html<br />
extension/action_popup.js<br />
extension/constants.js<br />
extension/extension.js<br />
extension/icons/plasma-disabled-128.png<br />
extension/manifest.json</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, VDG, fvogt<br /><strong>Cc: </strong>plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>