<table><tr><td style="">ivan requested changes to this revision.<br />ivan added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23112">View Revision</a></tr></table><br /><div><div><p>Thanks for geting involved this much!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23112#inline-130483">View Inline</a><span style="color: #4b4d51; font-weight: bold;">GtkEventSpy.cpp:129</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// remove "'" caracters wrapping the command</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">exec</span> <span style="color: #aa2211">=</span> <span class="n">exec</span><span class="p">.</span><span class="n">mid</span><span class="p">(</span><span style="color: #601200">1</span><span class="p">,</span> <span class="n">exec</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">-</span><span style="color: #601200">2</span> <span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It might be dangerous to assume that the command is wrapped with single quotes</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23112#inline-130484">View Inline</a><span style="color: #4b4d51; font-weight: bold;">GtkEventSpy.cpp:133</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// See https://techbase.kde.org/Development/Tutorials/Services/Traders#The_KTrader_Query_Language</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">query</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span class="p">(</span><span style="color: #766510">"exist Exec and ((Exec ~~ '%1') or (exist GenericName and '%1' ~~ GenericName) or (exist Name and '%1' ~~ Name))"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">exec</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KService</span><span style="color: #aa2211">::</span><span class="n">List</span> <span class="n">services</span> <span style="color: #aa2211">=</span> <span class="n">KServiceTypeTrader</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">query</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Application"</span><span class="p">),</span> <span class="n">query</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const auto query</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23112#inline-130485">View Inline</a><span style="color: #4b4d51; font-weight: bold;">GtkEventSpy.cpp:134</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">query</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span class="p">(</span><span style="color: #766510">"exist Exec and ((Exec ~~ '%1') or (exist GenericName and '%1' ~~ GenericName) or (exist Name and '%1' ~~ Name))"</span><span class="p">).</span><span class="n">arg</span><span class="p">(</span><span class="n">exec</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KService</span><span style="color: #aa2211">::</span><span class="n">List</span> <span class="n">services</span> <span style="color: #aa2211">=</span> <span class="n">KServiceTypeTrader</span><span style="color: #aa2211">::</span><span class="n">self</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">query</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Application"</span><span class="p">),</span> <span class="n">query</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This should also be <tt style="background: #ebebeb; font-size: 13px;">const</tt>, other local variables as well</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D23112#inline-130487">View Inline</a><span style="color: #4b4d51; font-weight: bold;">GtkEventSpy.cpp:143</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// remove space and any caracter after</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">int</span> <span class="n">spaceIdex</span> <span style="color: #aa2211">=</span> <span class="n">exec</span><span class="p">.</span><span class="n">indexOf</span><span class="p">(</span><span style="color: #766510">" "</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">spaceIdex</span> <span style="color: #aa2211">!=</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Let's hope commands will never have spaces in them :)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R161 KActivity Manager Service</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23112">https://phabricator.kde.org/D23112</a></div></div><br /><div><strong>To: </strong>meven, Frameworks, ivan<br /><strong>Cc: </strong>broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>