<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22896">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22896#inline-130341">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SidebarMode.cpp:402</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QMenu</span> <span style="color: #aa2211">*</span><span class="n">menu</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QMenu</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringList</span> <span class="n">actionList</span> <span class="p">{</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"configure"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"help_contents"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"help_about_app"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"help_about_kde"</span><span class="p">)</span> <span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This leaks.<br />
<tt style="background: #ebebeb; font-size: 13px;">menu->setAttribute(Qt::WA_DeleteOnClose);</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22896#inline-130342">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SidebarMode.cpp:403</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QMenu</span> <span style="color: #aa2211">*</span><span class="n">menu</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">new</span> <span class="n">QMenu</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringList</span> <span class="n">actionList</span> <span class="p">{</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"configure"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"help_contents"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"help_about_app"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"help_about_kde"</span><span class="p">)</span> <span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span><span class="n">QAction</span> <span style="color: #aa2211">*</span><span style="color: #a0a000">a</span> <span class="p">:</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">collection</span><span style="color: #aa2211">-></span><span class="n">actions</span><span class="p">())</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">const</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22896#inline-130343">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SidebarMode.cpp:404</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QStringList</span> <span class="n">actionList</span> <span class="p">{</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"configure"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"help_contents"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"help_about_app"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"help_about_kde"</span><span class="p">)</span> <span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">for</span> <span class="p">(</span><span class="n">QAction</span> <span style="color: #aa2211">*</span><span style="color: #a0a000">a</span> <span class="p">:</span> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">collection</span><span style="color: #aa2211">-></span><span class="n">actions</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">actionList</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">a</span><span style="color: #aa2211">-></span><span class="n">objectName</span><span class="p">()))</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think it's better to iterate the list of actions and then get them from the collection. This way the order is also preserved correctly:</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">for (const QString &actionName : actionList) {
menu->addAction(d->collection->action(actionName);
}</pre></div></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22896#inline-130344">View Inline</a><span style="color: #4b4d51; font-weight: bold;">SidebarMode.cpp:410</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">connect</span><span class="p">(</span><span class="n">menu</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QMenu</span><span style="color: #aa2211">::</span><span class="n">aboutToHide</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[</span><span style="color: #aa4000">this</span><span class="p">]</span> <span class="p">()</span> <span class="p">{</span> <span class="n">QMetaObject</span><span style="color: #aa2211">::</span><span class="n">invokeMethod</span><span class="p">(</span><span class="n">d</span><span style="color: #aa2211">-></span><span class="n">quickWidget</span><span style="color: #aa2211">-></span><span class="n">rootObject</span><span class="p">(),</span> <span style="color: #766510">"closeMenu"</span><span class="p">);</span> <span class="p">}</span> <span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">menu</span><span style="color: #aa2211">-></span><span class="n">exec</span><span class="p">(</span><span class="n">position</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Don't <tt style="background: #ebebeb; font-size: 13px;">exec()</tt> in conjunction with QML, this is just asking for trouble. Use <tt style="background: #ebebeb; font-size: 13px;">popup()</tt> instead</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22896#inline-130345">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.qml:44</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">function</span> <span style="color: #004012">closeMenu</span><span class="p">()</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">mainColumn</span><span class="p">.</span><span style="color: #004012">actionMenuButton</span><span class="p">.</span><span style="color: #004012">checked</span> <span style="color: #aa2211">=</span> <span style="color: #000a65">false</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you instead do a <tt style="background: #ebebeb; font-size: 13px;">Q_PROPERTY(bool actionMenuVisible ...)</tt> in <tt style="background: #ebebeb; font-size: 13px;">systemsettings</tt> which you set <tt style="background: #ebebeb; font-size: 13px;">true</tt> before the menu opens and set <tt style="background: #ebebeb; font-size: 13px;">false</tt> in <tt style="background: #ebebeb; font-size: 13px;">aboutToHide</tt>. Then bind the <tt style="background: #ebebeb; font-size: 13px;">checked</tt> of the button to it.<br />
This way everything is in a predictable space and not called all over the place.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R124 System Settings</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22896">https://phabricator.kde.org/D22896</a></div></div><br /><div><strong>To: </strong>GB_2, Plasma, VDG, ngraham, mart<br /><strong>Cc: </strong>mart, filipf, ngraham, broulik, VDG, plasma-devel, Plasma, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>