<table><tr><td style="">broulik created this revision.<br />broulik added reviewers: Plasma, fvogt.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D23091">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>The spec says it must be called with a details callback [1]</p>
<p>[1] <a href="https://w3c.github.io/mediasession/#callbackdef-mediasessionactionhandler" class="remarkup-link" target="_blank" rel="noreferrer">https://w3c.github.io/mediasession/#callbackdef-mediasessionactionhandler</a></p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Given we don't support seeking, only the bare "details" with the action is implemented.</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">navigator.setActionHandler("nexttrack", (details) => {
console.log("next track", details);
});</pre></div>
<p>prints "next track nexttrack" now instead of "next track undefined"</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R856 Plasma Browser Integration</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D23091">https://phabricator.kde.org/D23091</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>extension/content-script.js</div></div></div><br /><div><strong>To: </strong>broulik, Plasma, fvogt<br /><strong>Cc: </strong>plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>