<table><tr><td style="">apol added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21524">View Revision</a></tr></table><br /><div><div><p>Is this only necessary for gtk2?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21524#inline-129440">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appearancegtk2.cpp:125</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QRegularExpression</span> <span class="n">regExp</span><span class="p">{</span><span class="n">propertyName</span> <span style="color: #aa2211">+</span> <span style="color: #766510">"=[^</span><span style="color: #bb6622">\n</span><span style="color: #766510">]*($|</span><span style="color: #bb6622">\n</span><span style="color: #766510">)"</span><span class="p">};</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">const?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21524#inline-129437">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appearancegtk2.cpp:136</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">nonStringProperties</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">propertyName</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">newConfigString</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span class="p">{</span><span class="n">propertyName</span> <span style="color: #aa2211">+</span> <span style="color: #766510">"="</span> <span style="color: #aa2211">+</span> <span class="n">newValue</span> <span style="color: #aa2211">+</span> <span style="color: #766510">"</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span><span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This constructor isn't necessary.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21524#inline-129438">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appearancegtk2.cpp:138</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">newConfigString</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span class="p">{</span><span class="n">propertyName</span> <span style="color: #aa2211">+</span> <span style="color: #766510">"=</span><span style="color: #bb6622">\"</span><span style="color: #766510">"</span> <span style="color: #aa2211">+</span> <span class="n">newValue</span> <span style="color: #aa2211">+</span> <span style="color: #766510">"</span><span style="color: #bb6622">\"\n</span><span style="color: #766510">"</span><span class="p">};</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This constructor isn't necessary</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21524#inline-129439">View Inline</a><span style="color: #4b4d51; font-weight: bold;">appearancegtk2.cpp:143</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">fileContents</span><span class="p">.</span><span class="n">replace</span><span class="p">(</span><span class="n">regExp</span><span class="p">,</span> <span class="n">newConfigString</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="p">}</span> <span style="color: #aa4000">else</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">fileContents</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span class="p">{</span><span class="n">newConfigString</span> <span style="color: #aa2211">+</span> <span style="color: #766510">"</span><span style="color: #bb6622">\n</span><span style="color: #766510">"</span><span class="p">}</span> <span style="color: #aa2211">+</span> <span class="n">fileContents</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This constructor isn't necessary.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R99 KDE Gtk Configuration Tool</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21524">https://phabricator.kde.org/D21524</a></div></div><br /><div><strong>To: </strong>gikari, apol, Plasma<br /><strong>Cc: </strong>ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>