<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22945">View Revision</a></tr></table><br /><div><div><p>Also can you split the crash fix and <tt style="background: #ebebeb; font-size: 13px;">--replace</tt> option change please</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22945#inline-129456">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:136</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">corona</span><span style="color: #aa2211">-></span><span class="n">setShell</span><span class="p">(</span><span class="n">cliOptions</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">shellPluginOption</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QObject</span><span style="color: #aa2211">::</span><span class="n">connect</span><span class="p">(</span><span class="n">QCoreApplication</span><span style="color: #aa2211">::</span><span class="n">instance</span><span class="p">(),</span> <span style="color: #aa2211">&</span><span class="n">QCoreApplication</span><span style="color: #aa2211">::</span><span class="n">aboutToQuit</span><span class="p">,</span> <span class="n">corona</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QObject</span><span style="color: #aa2211">::</span><span class="n">deleteLater</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you explain? The <tt style="background: #ebebeb; font-size: 13px;">ShellCorona</tt> is parented to the app, so is destroyed with it. Is the <tt style="background: #ebebeb; font-size: 13px;">deleteLater</tt> even still processed at this point?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22945#inline-129452">View Inline</a><span style="color: #4b4d51; font-weight: bold;">main.cpp:182</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">while</span> <span class="p">(</span><span class="n">QDBusConnection</span><span style="color: #aa2211">::</span><span class="n">sessionBus</span><span class="p">().</span><span class="n">interface</span><span class="p">()</span><span style="color: #aa2211">-></span><span class="n">isServiceRegistered</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"org.kde.plasmashell"</span><span class="p">)))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">QCoreApplication</span><span style="color: #aa2211">::</span><span class="n">processEvents</span><span class="p">(</span><span class="n">QEventLoop</span><span style="color: #aa2211">::</span><span class="n">AllEvents</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">So this will just eat CPU until the other process quit?<br />
Can we register <tt style="background: #ebebeb; font-size: 13px;">org.kde.plasmashell</tt> service with <tt style="background: #ebebeb; font-size: 13px;">AllowReplace</tt> flag so the new process can just take over?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22945">https://phabricator.kde.org/D22945</a></div></div><br /><div><strong>To: </strong>apol<br /><strong>Cc: </strong>broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>