<table><tr><td style="">filipf accepted this revision as: filipf.<br />filipf added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22871">View Revision</a></tr></table><br /><div><div><p>Looks OK, along with these two inline comments I'd also add some reasoning for the change to the commit message.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22871#inline-129089">View Inline</a><span style="color: #4b4d51; font-weight: bold;">index.docbook:28</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><para>This is a module to configure <span class="bright">global options for </span>the <span class="bright">&plasma;</span> workspace.
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><para>This is a module to configure the <span class="bright">general</span> workspace<span class="bright"> behavior</span>.
</div><div style="padding: 0 8px; margin: 0 4px; "></para>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'd drop the "the"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22871#inline-129088">View Inline</a><span style="color: #4b4d51; font-weight: bold;">workspaceoptions.cpp:42</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"1.1"</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"System Settings module for <span class="bright">manag</span>ing <span class="bright">global options for </span>the <span class="bright">Plasma W</span>orkspace."</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"System Settings module for <span class="bright">configur</span>ing the <span class="bright">general w</span>orkspace<span class="bright"> behavior</span>."</span><span class="p">),</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KAboutLicense</span><span style="color: #aa2211">::</span><span class="n">GPL</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I'd drop the "the"</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>use-better-global-workspace-behavior-kcm-title-and-icon (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22871">https://phabricator.kde.org/D22871</a></div></div><br /><div><strong>To: </strong>GB_2, Plasma, VDG, filipf<br /><strong>Cc: </strong>filipf, kde-doc-english, ngraham, VDG, plasma-devel, Plasma, LeGast00n, jraleigh, gennad, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>