<table><tr><td style="">GB_2 accepted this revision as: VDG, GB_2.<br />GB_2 added a comment.<br />This revision is now accepted and ready to land.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22879">View Revision</a></tr></table><br /><div><div><p>We should probably also change the name in the KDE Store and Look and Feel Explorer.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22879#inline-129107">View Inline</a><span style="color: #4b4d51; font-weight: bold;">metadata.desktop:2</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">[Desktop Entry]
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">Comment=Test <span class="bright">L</span>ook and <span class="bright">F</span>eel package
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">Comment=Test <span class="bright">global l</span>ook and <span class="bright">f</span>eel package
</div><div style="padding: 0 8px; margin: 0 4px; ">Comment[ast]=Paquete d'aspeutu y sentir de prueba
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">"Test global theme package" or maybe "Test global look and feel"</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22879#inline-129109">View Inline</a><span style="color: #4b4d51; font-weight: bold;">lnftool.cpp:42</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">// About data</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">KAboutData</span> <span class="n">aboutData</span><span class="p">(</span><span style="color: #766510">"lookandfeeltool"</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Look and feel tool"</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">version</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Command line tool to apply look and feel packages</span>."</span><span class="p">),</span> <span class="n">KAboutLicense</span><span style="color: #aa2211">::</span><span class="n">GPL</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Copyright 2017, Marco Martin"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">KAboutData</span> <span class="n">aboutData</span><span class="p">(</span><span style="color: #766510">"lookandfeeltool"</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"<span class="bright">Global Theme tool"</span></span><span class="bright"></span><span class="p"><span class="bright">),</span></span><span class="bright"> </span><span class="n"><span class="bright">version</span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span class="n"><span class="bright">i18n</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"Command line tool to apply global theme packages for changing the look and feel</span>."</span><span class="p">),</span> <span class="n">KAboutLicense</span><span style="color: #aa2211">::</span><span class="n">GPL</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Copyright 2017, Marco Martin"</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">aboutData</span><span class="p">.</span><span class="n">addAuthor</span><span class="p">(</span><span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Marco Martin"</span><span class="p">),</span> <span class="n">i18n</span><span class="p">(</span><span style="color: #766510">"Maintainer"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"mart@kde.org"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Uppercase T in "tool" while at it :-)</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>lnf-to-global (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22879">https://phabricator.kde.org/D22879</a></div></div><br /><div><strong>To: </strong>ngraham, VDG, Plasma, GB_2<br /><strong>Cc: </strong>GB_2, plasma-devel, LeGast00n, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>