<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22700">View Revision</a></tr></table><br /><div><div><p>One potentially major issue that if I'm right needs fixing ASAP</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22700#inline-128167">View Inline</a><span style="color: #4b4d51; font-weight: bold;">advanceconfig.cpp:156</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">KConfigGroup</span> <span style="color: #004012">dpiConfigGroup</span><span class="p">(</span><span style="color: #aa2211">&</span><span class="n">dpiConfig</span><span class="p">,</span> <span style="color: #766510">"General"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">dpiValue</span> <span style="color: #aa2211">=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"-dpi "</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">dpiConfigGroup</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"forceFontDPI"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What are you going to write if this entry is missing?</p>
<p style="padding: 0; margin: 8px;">I suspect you'll write just</p>
<p style="padding: 0; margin: 8px;">"-dpi " into ServerArguments</p>
<p style="padding: 0; margin: 8px;">and then X11 will run with "X11 -dpi" expect another argument and simply fail to load?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22700#inline-128168">View Inline</a><span style="color: #4b4d51; font-weight: bold;">advanceconfig.cpp:157</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">dpiValue</span> <span style="color: #aa2211">=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"-dpi "</span><span class="p">)</span> <span style="color: #aa2211">+</span> <span class="n">dpiConfigGroup</span><span class="p">.</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"forceFontDPI"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">KConfig</span> <span style="color: #004012">numLockConfig</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"kcminputrc"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">As a coding note it's useful to make sure the data in the variables matches their name.</p>
<p style="padding: 0; margin: 8px;">In this case</p>
<p style="padding: 0; margin: 8px;">"dpiValue" isn't just the DPI value, it's a string formatted as X server arguments "-dpi" here.</p>
<p style="padding: 0; margin: 8px;">So I would suggest either renaming or (probably easier with the other fix) adding the "-dpi "prefix when you insert it into the map.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R123 SDDM Configuration Panel (KCM)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22700">https://phabricator.kde.org/D22700</a></div></div><br /><div><strong>To: </strong>filipf, Plasma, davidedmundson, ngraham<br /><strong>Cc: </strong>plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>