<table><tr><td style="">sitter accepted this revision.<br />sitter added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22322">View Revision</a></tr></table><br /><div><div><p>some style fixes then ship it plz 👍</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22322#inline-126289">View Inline</a><span style="color: #4b4d51; font-weight: bold;">drkonqi.cpp:214</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">void</span> <span style="color: #004012">removeOldFilesIn</span><span class="p">(</span><span class="n">QDir</span><span style="color: #aa2211">&</span> <span class="n">dir</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">auto</span> <span class="n">fileList</span> <span style="color: #aa2211">=</span> <span class="n">dir</span><span class="p">.</span><span class="n">entryInfoList</span><span class="p">(</span><span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">Files</span> <span style="color: #aa2211">|</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">NoDotAndDotDot</span><span class="p">,</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">& goes to the right of the space; curly brace goes on next line for multi-line function bodies</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22322#inline-126370">View Inline</a><span style="color: #4b4d51; font-weight: bold;">drkonqi.cpp:217</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                                          <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">SortFlag</span><span style="color: #aa2211">::</span><span class="n">Time</span> <span style="color: #aa2211">|</span> <span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">Reversed</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">fileList</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">>=</span> <span style="color: #601200">10</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">int</span> <span class="n">filesToRemove</span> <span style="color: #aa2211">=</span> <span class="n">fileList</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span style="color: #601200">9</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This doesn't necessarily need changing, but I want to point out that this and the following two lines are convoluted, they are simply <tt style="background: #ebebeb; font-size: 13px;">for (int i = fileList.size(); i <= 10; --i) {}</tt> if I am reading this right.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22322#inline-126367">View Inline</a><span style="color: #4b4d51; font-weight: bold;">drkonqi.cpp:219</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">int</span> <span class="n">filesToRemove</span> <span style="color: #aa2211">=</span> <span class="n">fileList</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span style="color: #aa2211">-</span> <span style="color: #601200">9</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span style="color: #aa4000">while</span><span class="p">(</span><span class="n">filesToRemove</span><span style="color: #aa2211">--</span><span class="p">)</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span style="color: #aa4000">auto</span> <span class="n">currentFile</span> <span style="color: #aa2211">=</span> <span class="n">fileList</span><span class="p">.</span><span class="n">takeFirst</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">space between while and brace</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22322#inline-126368">View Inline</a><span style="color: #4b4d51; font-weight: bold;">drkonqi.cpp:232</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QDir</span> <span class="n">dir</span><span class="p">(</span><span class="n">dirname</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span style="color: #aa4000">if</span><span class="p">(</span><span style="color: #aa2211">!</span><span class="n">dir</span><span class="p">.</span><span class="n">mkpath</span><span class="p">(</span><span class="n">dirname</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="n">qApp</span><span style="color: #aa2211">-></span><span class="n">quit</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">space between if and brace</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R871 DrKonqi</div></div></div><br /><div><strong>BRANCH</strong><div><div>storeGuiless</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22322">https://phabricator.kde.org/D22322</a></div></div><br /><div><strong>To: </strong>tcanabrava, sitter, davidedmundson<br /><strong>Cc: </strong>sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>