<table><tr><td style="">sitter added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22322">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D22322#492240" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">D22322#492240</a>, <a href="https://phabricator.kde.org/p/davidedmundson/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>What's the rationale behind this change? Isn't this use case covered by coredumpd and the like?</p></blockquote>
<p>Well, by that logic we wouldn't have any drkonqi...</p></div>
</blockquote>
<p>I don't see how.</p>
<p>Drkonqi is and interactive crash reporter, coredumpd is a non-interactive crash catcher. What the diff is doing is taking away the interactivity of drkonqi in certain cases, and that looks to me like we are simply replicating coredumpd at this point. Specifically the diff adds nothing on top of what coredumpd already does, in fact it's worse because we currently don't capture cores, so you couldn't retrace our saved trace with possibly missing debug symbols.</p>
<p>The interactive way of handling a crash on logout would be to show drkonqi and let the user file a bug report. Now I understand this isn't all that reliable, so I would discard the crash and just exit under the assumption that a kernel core pattern (e.g. coredumpd) will deal with the crash.</p>
<p>If you are adamant about this diff I think we need at least a cleanup system to enforce a hard limit on how many traces we keep around, and/or traces of how many logins ago, and/or how many MiB they may consume. Otherwise people are going to get annoyed when there disk is full in a year because the ffmpegthumbnailer crashed a gazillion times ^^</p>
<p>And perhaps more ideally, albeit not blocking this diff, we should look at reshuffling the architecture so on next login drkonqi auto starts with a list of crashes and the ability to file reports for them.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22322#inline-125935">View Inline</a><span style="color: #4b4d51; font-weight: bold;">drkonqi.cpp:226</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span class="n">QString</span> <span class="n">defname</span> <span style="color: #aa2211">=</span> <span class="n">dirname</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa2211">+</span> <span class="n">QLatin1Char</span><span class="p">(</span><span style="color: #766510">'/'</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Needs to include pid. I can have multiple kwrites running and they could all be crashing.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R871 DrKonqi</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22322">https://phabricator.kde.org/D22322</a></div></div><br /><div><strong>To: </strong>tcanabrava<br /><strong>Cc: </strong>sitter, davidedmundson, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>