<table><tr><td style="">msdobrescu added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22121">View Revision</a></tr></table><br /><div><div><p>IMHO, for lines like these, 'm_currentSlide = m_slideFilterModel->indexOf(path) - 1;', checks must be added because it is transparent to the QML code and let room for failure.</p>
<p>Besides that, did you know that if there are no wallpapers, could be added one or more by drag and drop?<br />
Image files could be added by drag and drop, but never appear, although they are in the list, where should be folders only IMHO.<br />
They stay there, nothing happens, no background change on the desktop.<br />
Also, if a folder is added, 'Apply' button pressed, then removed, after 'Apply', the background remains set to the last image, although I would have expected to have no image set as wallpaper.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22121#inline-125747">View Inline</a><span style="color: #4b4d51; font-weight: bold;">davidre</span> wrote in <span style="color: #4b4d51; font-weight: bold;">image.cpp:600</span></div>
<div style="margin: 8px 0; padding: 0 12px; color: #74777D;"><p style="padding: 0; margin: 8px;">Currently the slideshow would restart. I guess we could check here if the index is -1. Or alternatively don't trigger this from the qml side if the image is unchecked. In my mind this even better because then we enable the apply button, too.</p></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">IMHO, here must be checked because it is transparent to the QML code and lets room for failure.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22121">https://phabricator.kde.org/D22121</a></div></div><br /><div><strong>To: </strong>davidre, Plasma, davidedmundson<br /><strong>Cc: </strong>davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>