<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22191">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22191#inline-125062">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sddmauthhelper.cpp:76</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QStringList</span> <span class="n">sourceDirEntries</span> <span style="color: #aa2211">=</span> <span class="n">sourceDirectory</span><span class="p">.</span><span class="n">entryList</span> <span class="p">(</span><span class="n">QDir</span><span style="color: #aa2211">::</span><span class="n">AllDirs</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">QDir</span> <span style="color: #004012">destination</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"/var/lib/sddm/.config/fontconfig/"</span><span class="p">));</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Don't hardcode /var/lib/sddm</p>

<p style="padding: 0; margin: 8px;">KUser("sddm").homeDir() would be better</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22191#inline-125064">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sddmauthhelper.cpp:118</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">//QDir cacheDir(QStringLiteral("/var/lib/sddm/.cache/"));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">args</span><span class="p">[</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"sddmUserConfig"</span><span class="p">)].</span><span class="n">isNull</span><span class="p">())</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">fontconfigDir</span><span class="p">.</span><span class="n">removeRecursively</span><span class="p">();</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">What's the point of this argument when you hardcode/evaluate it so much in this file.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22191#inline-125063">View Inline</a><span style="color: #4b4d51; font-weight: bold;">advanceconfig.cpp:40</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="n">AdvanceConfig</span><span style="color: #aa2211">::</span><span class="n">AdvanceConfig</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KSharedConfigPtr</span> <span style="color: #aa2211">&</span><span class="n">config</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">QWidget</span></span> <span style="color: #aa2211">*</span><span class="n">parent</span><span class="p">)</span> <span style="color: #aa2211">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">AdvanceConfig</span><span style="color: #aa2211">::</span><span class="n">AdvanceConfig</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">KSharedConfigPtr</span> <span style="color: #aa2211">&</span><span class="n">config</span><span class="p">,</span> <span class="bright"></span><span class="n"><span class="bright">KCModule</span></span> <span style="color: #aa2211">*</span><span class="n">parent</span><span class="p">)</span> <span style="color: #aa2211">:</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QWidget</span><span class="p">(</span><span class="n">parent</span><span class="p">),</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">we ended up not needing to access KCModule from this class</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R123 SDDM Configuration Panel (KCM)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22191">https://phabricator.kde.org/D22191</a></div></div><br /><div><strong>To: </strong>filipf, Plasma, ngraham, davidedmundson, VDG<br /><strong>Cc: </strong>plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>