<table><tr><td style="">zzag added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D22084">View Revision</a></tr></table><br /><div><div><p>Hmm, okay, I see what the problem is.</p>

<p>The proposed patch seems to be reasonable, but I don't like the new object tree. We could fix this bug by introducing m_isTerminating, e.g.</p>

<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="cpp" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);"><span style="color: #74777d">// In setupKWaylandIntegration.</span>
<span class="n">connect</span><span class="p">(</span><span class="n">qApp</span><span class="p">,</span> <span style="color: #aa2211">&</span><span class="n">QCoreApplication</span><span style="color: #aa2211">::</span><span class="n">aboutToQuick</span><span class="p">,</span> <span style="color: #aa4000">this</span><span class="p">,</span> <span class="p">[]</span> <span class="p">{</span>
    <span style="color: #74777d">// ...</span>
    <span class="n">m_registry</span><span style="color: #aa2211">-></span><span class="n">release</span><span class="p">();</span>
    <span class="n">m_isTerminating</span> <span style="color: #aa2211">=</span> <span style="color: #304a96">true</span><span class="p">;</span>
<span class="p">});</span>

<span style="color: #74777d">// In each proxy getter.</span>

<span style="color: #74777d">// A deep touching comment that explains why this proxy is guarded.</span>
<span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">m_isTerminating</span><span class="p">)</span> <span class="p">{</span>
    <span style="color: #aa4000">return</span> <span style="color: #aa4000">nullptr</span><span class="p">;</span>
<span class="p">}</span></pre></div>

<p>these two approaches are inter-changeable, but solution with m_isTerminating has a bit nicer object tree.</p>

<p>In either case, this patch is good to go. I have just one question.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D22084#inline-124384">View Inline</a><span style="color: #4b4d51; font-weight: bold;">waylandintegration.cpp:125</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">                <span class="n">m_waylandBlurManager</span><span style="color: #aa2211">-></span><span class="n">deleteLater</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                <span class="n">m_waylandBlurManager</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">nullptr</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Is it safe to drop this line? What was the reasoning behind this change?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R130 Frameworks integration plugin using KWayland</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D22084">https://phabricator.kde.org/D22084</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>apol, ngraham, anthonyfieroni, zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>