<table><tr><td style="">sitter updated this revision to Diff 60058.<br />sitter added a comment.

</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19612">View Revision</a></tr></table><br /><div><div><ul class="remarkup-list">

<li class="remarkup-list-item">refactor</li>

<li class="remarkup-list-item">move clients to subdir</li>

<li class="remarkup-list-item">catch all exceptions</li>

<li class="remarkup-list-item">don't incorrectly init the static</li>

<li class="remarkup-list-item">cleanup includes</li>

<li class="remarkup-list-item">more tests and less asserts</li>

<li class="remarkup-list-item">litter--</li>

<li class="remarkup-list-item">split commands</li>

<li class="remarkup-list-item">throw out a whole bunch of warnings and bring up coverage</li>

</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R871 DrKonqi</div></div></div><br /><div><strong>CHANGES SINCE LAST UPDATE</strong><div><a href="https://phabricator.kde.org/D19612?vs=53953&id=60058">https://phabricator.kde.org/D19612?vs=53953&id=60058</a></div></div><br /><div><strong>BRANCH</strong><div><div>webservice</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19612">https://phabricator.kde.org/D19612</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />

src/CMakeLists.txt<br />

src/aboutbugreportingdialog.cpp<br />

src/bugzillaintegration/bugzillalib.cpp<br />

src/bugzillaintegration/bugzillalib.h<br />

src/bugzillaintegration/duplicatefinderjob.cpp<br />

src/bugzillaintegration/duplicatefinderjob.h<br />

src/bugzillaintegration/libbugzilla/CMakeLists.txt<br />

src/bugzillaintegration/libbugzilla/apijob.cpp<br />

src/bugzillaintegration/libbugzilla/apijob.h<br />

src/bugzillaintegration/libbugzilla/apireply.cpp<br />

src/bugzillaintegration/libbugzilla/apireply.h<br />

src/bugzillaintegration/libbugzilla/autotests/CMakeLists.txt<br />

src/bugzillaintegration/libbugzilla/autotests/attachmenttest.cpp<br />

src/bugzillaintegration/libbugzilla/autotests/bugtest.cpp<br />

src/bugzillaintegration/libbugzilla/autotests/bugzillatest.cpp<br />

src/bugzillaintegration/libbugzilla/autotests/commenttest.cpp<br />

src/bugzillaintegration/libbugzilla/autotests/connectiontest.cpp<br />

src/bugzillaintegration/libbugzilla/autotests/data/attachment.new.json<br />

src/bugzillaintegration/libbugzilla/autotests/data/bugs.dragonplayer.json<br />

src/bugzillaintegration/libbugzilla/autotests/data/bugs.new.json<br />

src/bugzillaintegration/libbugzilla/autotests/data/bugs.update.json<br />

src/bugzillaintegration/libbugzilla/autotests/data/bugzilla.login.json<br />

src/bugzillaintegration/libbugzilla/autotests/data/bugzilla.version.json<br />

src/bugzillaintegration/libbugzilla/autotests/data/comments.json<br />

src/bugzillaintegration/libbugzilla/autotests/data/error.http<br />

src/bugzillaintegration/libbugzilla/autotests/data/hi.http<br />

src/bugzillaintegration/libbugzilla/autotests/data/product.dragonplayer.json<br />

src/bugzillaintegration/libbugzilla/autotests/data/put.http<br />

src/bugzillaintegration/libbugzilla/autotests/producttest.cpp<br />

src/bugzillaintegration/libbugzilla/bugzilla.cpp<br />

src/bugzillaintegration/libbugzilla/bugzilla.h<br />

src/bugzillaintegration/libbugzilla/clients/attachmentclient.cpp<br />

src/bugzillaintegration/libbugzilla/clients/attachmentclient.h<br />

src/bugzillaintegration/libbugzilla/clients/bugclient.cpp<br />

src/bugzillaintegration/libbugzilla/clients/bugclient.h<br />

src/bugzillaintegration/libbugzilla/clients/clientbase.cpp<br />

src/bugzillaintegration/libbugzilla/clients/clientbase.h<br />

src/bugzillaintegration/libbugzilla/clients/commands/bugsearch.cpp<br />

src/bugzillaintegration/libbugzilla/clients/commands/bugsearch.h<br />

src/bugzillaintegration/libbugzilla/clients/commands/bugupdate.cpp<br />

src/bugzillaintegration/libbugzilla/clients/commands/bugupdate.h<br />

src/bugzillaintegration/libbugzilla/clients/commands/commandbase.h<br />

src/bugzillaintegration/libbugzilla/clients/commands/jsoncommand.cpp<br />

src/bugzillaintegration/libbugzilla/clients/commands/jsoncommand.h<br />

src/bugzillaintegration/libbugzilla/clients/commands/newattachment.cpp<br />

src/bugzillaintegration/libbugzilla/clients/commands/newattachment.h<br />

src/bugzillaintegration/libbugzilla/clients/commands/newbug.cpp<br />

src/bugzillaintegration/libbugzilla/clients/commands/newbug.h<br />

src/bugzillaintegration/libbugzilla/clients/commands/querycommand.cpp<br />

src/bugzillaintegration/libbugzilla/clients/commands/querycommand.h<br />

src/bugzillaintegration/libbugzilla/clients/commentclient.cpp<br />

src/bugzillaintegration/libbugzilla/clients/commentclient.h<br />

src/bugzillaintegration/libbugzilla/clients/productclient.cpp<br />

src/bugzillaintegration/libbugzilla/clients/productclient.h<br />

src/bugzillaintegration/libbugzilla/connection.cpp<br />

src/bugzillaintegration/libbugzilla/connection.h<br />

src/bugzillaintegration/libbugzilla/exceptions.cpp<br />

src/bugzillaintegration/libbugzilla/exceptions.h<br />

src/bugzillaintegration/libbugzilla/models/attachment.cpp<br />

src/bugzillaintegration/libbugzilla/models/attachment.h<br />

src/bugzillaintegration/libbugzilla/models/bug.cpp<br />

src/bugzillaintegration/libbugzilla/models/bug.h<br />

src/bugzillaintegration/libbugzilla/models/comment.cpp<br />

src/bugzillaintegration/libbugzilla/models/comment.h<br />

src/bugzillaintegration/libbugzilla/models/logindetails.cpp<br />

src/bugzillaintegration/libbugzilla/models/logindetails.h<br />

src/bugzillaintegration/libbugzilla/models/product.cpp<br />

src/bugzillaintegration/libbugzilla/models/product.h<br />

src/bugzillaintegration/parsebugbacktraces.cpp<br />

src/bugzillaintegration/parsebugbacktraces.h<br />

src/bugzillaintegration/productmapping.cpp<br />

src/bugzillaintegration/productmapping.h<br />

src/bugzillaintegration/reportassistantpages_base.cpp<br />

src/bugzillaintegration/reportassistantpages_bugzilla.cpp<br />

src/bugzillaintegration/reportassistantpages_bugzilla.h<br />

src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp<br />

src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.h<br />

src/bugzillaintegration/reportinterface.cpp<br />

src/bugzillaintegration/reportinterface.h<br />

src/config-drkonqi.h.cmake<br />

src/data/debuggers/external.mac/lldbrc<br />

src/data/debuggers/external/cdbrc<br />

src/data/debuggers/external/lldbrc<br />

src/data/debuggers/internal/cdbrc<br />

src/data/debuggers/internal/lldbrc<br />

src/data/mappings<br />

src/debugger.cpp<br />

src/debuggerlaunchers.cpp<br />

src/debuggerlaunchers.h<br />

src/drkonqi.cpp<br />

src/drkonqibackends.cpp<br />

src/drkonqidialog.cpp<br />

src/kdbgwin/CMakeLists.txt<br />

src/kdbgwin/abstract_generator.h<br />

src/kdbgwin/kdbgwin_process.cpp<br />

src/kdbgwin/kdbgwin_process.h<br />

src/kdbgwin/main.cpp<br />

src/kdbgwin/mingw_generator.cpp<br />

src/kdbgwin/msvc_generator.cpp<br />

src/kdbgwin/process.cpp<br />

src/kdbgwin/process.h<br />

src/main.cpp<br />

src/org.kde.drkonqi.desktop.cmake<br />

src/parser/CMakeLists.txt<br />

src/parser/backtraceparser.cpp<br />

src/parser/backtraceparsercdb.cpp<br />

src/parser/backtraceparsercdb.h<br />

src/ptracer.cpp<br />

src/ptracer.h<br />

src/statusnotifier.cpp<br />

src/tests/crashtest/crashtest.cpp</div></div></div><br /><div><strong>To: </strong>sitter<br /><strong>Cc: </strong>plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>