<table><tr><td style="">davidedmundson requested changes to this revision.<br />davidedmundson added inline comments.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21832">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21832#inline-122905">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sddmauthhelper.cpp:86</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #74777d">// see: https://github.com/sddm/sddm/blob/develop/src/common/ConfigReader.cpp#L144</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">fileName</span> <span style="color: #aa2211">==</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"sddm.conf"</span><span class="p">)</span> <span style="color: #aa2211">&&</span> <span class="p">(</span><span class="n">args</span><span class="p">.</span><span class="n">count</span><span class="p">(</span><span class="n">keyName</span><span class="p">)</span> <span style="color: #aa2211">></span> <span style="color: #601200">1</span><span class="p">))</span> <span class="p">{</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">sddmOldConfig</span><span style="color: #aa2211">-></span><span class="n">group</span><span class="p">(</span><span class="n">groupName</span><span class="p">).</span><span class="n">deleteEntry</span><span class="p">(</span><span class="n">keyName</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">if something is going into the file "kde_settings.conf" then we want to remove it from sddmOldConfig</p>
<p style="padding: 0; margin: 8px;">Nothing in args is sent with this filename</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21832#inline-122901">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sddmkcm.cpp:60</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">mSddmConfig</span> <span style="color: #aa2211">=</span> <span class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span class="n">openConfig</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">SDDM_CONFIG_FILE</span></span><span class="p">),</span> <span class="n">KConfig</span><span style="color: #aa2211">::</span><span class="n">CascadeConfig</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">mSddmConfig</span> <span style="color: #aa2211">=</span> <span class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span class="n">openConfig</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"kde_settings.conf"</span></span><span class="p">),</span> <span class="n">KConfig</span><span style="color: #aa2211">::</span><span class="n">CascadeConfig</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This file doesn't need to be changed at all</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21832#inline-122902">View Inline</a><span style="color: #4b4d51; font-weight: bold;">sddmkcm.cpp:74</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">mSddmConfig</span><span style="color: #aa2211">-></span><span class="n">addConfigSources</span><span class="p">(</span><span class="n">systemConfigFiles</span> <span style="color: #aa2211">+</span> <span class="n">configFiles</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">mSddmOldConfig</span><span style="color: #aa2211">-></span><span class="n">addConfigSources</span><span class="p">(</span><span class="n">systemConfigFiles</span> <span style="color: #aa2211">+</span> <span class="n">configFiles</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">as it's all done here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21832#inline-122903">View Inline</a><span style="color: #4b4d51; font-weight: bold;">themesmodel.cpp:93</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="n">QString</span> <span class="n">themesBaseDir</span> <span style="color: #aa2211">=</span> <span class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span class="n">openConfig</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span class="n"><span class="bright">SDDM_CONFIG_FILE</span></span><span class="p">),</span> <span class="n">KConfig</span><span style="color: #aa2211">::</span><span class="n">SimpleConfig</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">group</span><span class="p">(</span><span style="color: #766510">"Theme"</span><span class="p">).</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"ThemeDir"</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">QString</span> <span class="n">themesBaseDir</span> <span style="color: #aa2211">=</span> <span class="n">KSharedConfig</span><span style="color: #aa2211">::</span><span class="n">openConfig</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(<span class="bright"></span></span><span class="bright"></span><span style="color: #766510"><span class="bright">"kde_settings.conf"</span></span><span class="p">),</span> <span class="n">KConfig</span><span style="color: #aa2211">::</span><span class="n">SimpleConfig</span><span class="p">)</span><span style="color: #aa2211">-></span><span class="n">group</span><span class="p">(</span><span style="color: #766510">"Theme"</span><span class="p">).</span><span class="n">readEntry</span><span class="p">(</span><span style="color: #766510">"ThemeDir"</span><span class="p">);</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">this needs to be using the same logic as sddmkcm.cpp</p>
<p style="padding: 0; margin: 8px;">probably easier if they share the same kconfig instance</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R123 SDDM Configuration Panel (KCM)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21832">https://phabricator.kde.org/D21832</a></div></div><br /><div><strong>To: </strong>filipf, davidedmundson, ngraham, Plasma<br /><strong>Cc: </strong>plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>