<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21810">View Revision</a></tr></table><br /><div><div><p>TBH I really don't like this message anyway. It's so in-your-face. But while it exists, I guess we should make it look prettier. :)</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21810#inline-122806">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigurationContainmentAppearance.qml:83</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">Item</span> <span class="p">{</span> <span style="color: #74777d">// spacer; we need it because we set ColumnLayout's spacing to 0</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">visible:</span> <span style="color: #004012">lockedWidgetsMessage</span><span class="p">.</span><span style="color: #004012">visible</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Instead of adding a whole new item with conditional visibility, you could just add <tt style="background: #ebebeb; font-size: 13px;">Layout.bottomMargin: Kirigami.Units.smallSpacing * 2</tt> to the InlineMessage itself</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21810#inline-122807">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ConfigurationContainmentAppearance.qml:110</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #aa4000">visible:</span> <span style="color: #aa2211">!</span><span style="color: #004012">switchContainmentWarning</span><span class="p">.</span><span style="color: #004012">visible</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span style="color: #aa4000">Kirigami.FormData.label:</span> <span style="color: #004012">i18nd</span><span class="p">(</span><span style="color: #766510">"plasma_shell_org.kde.plasma.desktop"</span><span class="p">,</span> <span style="color: #766510">"Wallpaper <span class="bright">T</span>ype:"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Kirigami.FormData.label:</span> <span style="color: #004012">i18nd</span><span class="p">(</span><span style="color: #766510">"plasma_shell_org.kde.plasma.desktop"</span><span class="p">,</span> <span style="color: #766510">"Wallpaper <span class="bright">t</span>ype:"</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span style="color: #004012">QtControls</span><span class="p">.</span><span style="color: #004012">ComboBox</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is a string change which means it can't go into 5.16.1</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21810">https://phabricator.kde.org/D21810</a></div></div><br /><div><strong>To: </strong>filipf, VDG, ngraham<br /><strong>Cc: </strong>plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>