<table><tr><td style="">filipf added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21794">View Revision</a></tr></table><br /><div><div><p>Final comments and then it's a ship it from me!</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21794#inline-122784">View Inline</a><span style="color: #4b4d51; font-weight: bold;">BreezeMenuStyle.qml:12</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">property</span> <span style="color: #004012">color</span> <span style="color: #aa4000">borderColor:</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">ColorScope</span><span class="p">.</span><span style="color: #004012">textColor</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">border.color:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">rgba</span><span class="p">(</span><span style="color: #004012">borderColor</span><span class="p">.</span><span style="color: #004012">r</span><span class="p">,</span> <span style="color: #004012">borderColor</span><span class="p">.</span><span style="color: #004012">g</span><span class="p">,</span> <span style="color: #004012">borderColor</span><span class="p">.</span><span style="color: #004012">b</span><span class="p">,</span> <span style="color: #601200">0.3</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">border.width:</span> <span style="color: #601200">1</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">It's still not working right with dark themes:</p>
<p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/F6889724" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6889724: image.png</a></p>
<p style="padding: 0; margin: 8px;">What do you say we steal the code for kirigami's separator color?</p>
<ul class="remarkup-list">
<li class="remarkup-list-item">first we remove the <tt style="background: #ebebeb; font-size: 13px;">property color ...</tt> line above, and then do:</li>
</ul>
<p style="padding: 0; margin: 8px;"><tt style="background: #ebebeb; font-size: 13px;">border.color: Qt.tint(PlasmaCore.ColorScope.textColor, Qt.rgba(color.r, color.g, color.b, 0.7))</tt></p>
<p style="padding: 0; margin: 8px;">looks good now IMO:</p>
<p style="padding: 0; margin: 8px;"><a href="https://phabricator.kde.org/F6889733" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6889733: image.png</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21794#inline-122781">View Inline</a><span style="color: #4b4d51; font-weight: bold;">BreezeMenuStyle.qml:18</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">verticalAlignment:</span> <span style="color: #004012">Text</span><span class="p">.</span><span style="color: #004012">AlignVCenter</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">color:</span> <span style="color: #004012">styleData</span><span class="p">.</span><span style="color: #004012">selected</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">PlasmaCore.ColorScope.highlightedTextColor :</span> <span style="color: #004012">PlasmaCore</span><span class="p">.</span><span style="color: #004012">ColorScope</span><span class="p">.</span><span style="color: #004012">textColor</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">there's whitespace here</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21794#inline-122782">View Inline</a><span style="color: #4b4d51; font-weight: bold;">BreezeMenuStyle.qml:21</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">font.pointSize:</span> <span style="color: #004012">config</span><span class="p">.</span><span style="color: #004012">fontSize</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">text:</span> <span style="color: #004012">styleData</span><span class="p">.</span><span style="color: #004012">text</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">whitespace here as well</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21794">https://phabricator.kde.org/D21794</a></div></div><br /><div><strong>To: </strong>cblack, VDG, filipf<br /><strong>Cc: </strong>apol, plasma-devel, LeGast00n, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart<br /></div>