<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21725">View Revision</a></tr></table><br /><div><div><p>Concept ++</p>

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>Started different systems on different distros, on wayland and x11.</p></blockquote>

<p>Given this is a huge change, please expand on this and confirm we've covered all paths.</p>

<p>Debug needs cleaning (or QCDebug) before merge.</p>

<hr class="remarkup-hr" />

<blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>#preload the user's locale on first start</p></blockquote>

<p>is missing</p>

<hr class="remarkup-hr" /></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21725#inline-122166">View Inline</a><span style="color: #4b4d51; font-weight: bold;">startplasma.cpp:142</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">//TODO: consider linking directly</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">applyMouseStatus</span> <span style="color: #aa2211">=</span> <span class="n">wayland</span> <span style="color: #aa2211">?</span> <span style="color: #601200">0</span> <span style="color: #aa2211">:</span> <span class="n">runSync</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"kapplymousetheme"</span><span class="p">),</span> <span class="p">{</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"kcminputrc_mouse_cursortheme"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"kcminputrc_mouse_cursorsize"</span><span class="p">)</span> <span class="p">});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Don't yet.</p>

<p style="padding: 0; margin: 8px;">This being here is (I think) the result of a lazy hack due to env vars not getting synced properly from kcminit. I hope to address that.</p>

<p style="padding: 0; margin: 8px;">Obviously your port being a 1:1 clone is fine.</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21725#inline-122167">View Inline</a><span style="color: #4b4d51; font-weight: bold;">startplasma.cpp:258</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #74777d">// At this point all environment variables are set, let's send it to the DBus session server to update the activation environment</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: #aa2211">!</span><span class="n">QStandardPaths</span><span style="color: #aa2211">::</span><span class="n">findExecutable</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"dbus-update-activation-environment"</span><span class="p">)).</span><span class="n">isEmpty</span><span class="p">())</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">        <span class="n">exitCode</span> <span style="color: #aa2211">=</span> <span class="n">runSync</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"dbus-update-activation-environment"</span><span class="p">),</span> <span class="p">{</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"--systemd"</span><span class="p">),</span> <span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"--all"</span><span class="p">)</span> <span class="p">});</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">braces</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21725">https://phabricator.kde.org/D21725</a></div></div><br /><div><strong>To: </strong>apol, Plasma<br /><strong>Cc: </strong>davidedmundson, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>