<table><tr><td style="">sitter accepted this revision.<br />sitter added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21646">View Revision</a></tr></table><br /><div><div><p>LGTM. At a glance breezehelper caches values (loadConfig) and brezestyleconfigdata may as well, so this certainly seems sound. Specifically <tt style="background: #ebebeb; font-size: 13px;"> _viewFocusBrush = KStatefulBrush( KColorScheme::View, KColorScheme::FocusColor, _config );</tt> seems to be used to influence the focus color of checkboxes and that _config is in fact a StyleConfigData. So, this definitely needs a reload.</p>
<p>Is integration of qt4 software still a concern? If so, perhaps the colors KCM should also send the reparseConfiguration signal, seeing as that would cause a double reload on Qt5 we probably don't want that though.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R31 Breeze</div></div></div><br /><div><strong>BRANCH</strong><div><div>colorchangeeventfilter</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21646">https://phabricator.kde.org/D21646</a></div></div><br /><div><strong>To: </strong>sebas, Plasma, broulik, sitter<br /><strong>Cc: </strong>sitter, cfeck, broulik, zzag, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>