<table><tr><td style="">filipf accepted this revision.<br />filipf added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21629">View Revision</a></tr></table><br /><div><div><p>+1 buttons should be buttons unless there's really strong designer reasons such as in the login screen etc. I'm also enjoying this a lot more than than just having icons.</p>

<p>BTW when talking about consistency, do we also apply this change to the media player applet?</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21629#inline-121605">View Inline</a><span style="color: #4b4d51; font-weight: bold;">ToolTipInstance.qml:336</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                    <span class="bright">    </span><span style="color: #aa4000"><span class="bright">acceptedButtons:</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">Qt</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">Left</span>Button</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">                        <span class="bright"></span><span style="color: #aa4000"><span class="bright">hoverEnabled:</span></span><span class="bright"> </span><span style="color: #000a65"><span class="bright">true</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                    <span class="bright"></span><span style="color: #004012"><span class="bright">PlasmaComponents</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">Tool</span>Button<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">{</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                        <span class="bright"></span><span style="color: #74777d"><span class="bright">// TODO: make PlasmaComponents ToolButtons respond to size changes</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                        <span style="color: #74777d">// iconHeight: units.iconSizes.medium</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Do we also have the issue here that the tool button will grow in size but not the icon inside it? Seems OK when I bump up the scaling.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>use-toolbuttons-in-popup-delegates (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21629">https://phabricator.kde.org/D21629</a></div></div><br /><div><strong>To: </strong>ngraham, Plasma, VDG, ndavis, filipf<br /><strong>Cc: </strong>filipf, ndavis, plasma-devel, LeGast00n, ericadams, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>