<table><tr><td style="">leinir created this revision.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />leinir requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21510">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Following a lengthy discussion on the topic[1], the first step<br />
towards getting themes cleaned up and hidden when they don't<br />
work is to get the ones hidden which are only for Plasma 4.<br />
We do this by filtering out any theme which is tagged as<br />
being for the major version 4 of plasma. We also allow themes<br />
through which have been tested to work on both, by accepting<br />
themes which are tagged as both 4 and 5.</p>
<p>[1] <a href="https://phabricator.kde.org/T8126#184198" class="remarkup-link" target="_blank" rel="noreferrer">https://phabricator.kde.org/T8126#184198</a> and down a few pages</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>See themes tagged as plasma<tt style="background: #ebebeb; font-size: 13px;">majorversion=4 being hidden, except when they
are also tagged as plasma</tt>majorversion=5. This can most easily be done<br />
by launching the plasma theme dialog and opening Get New Themes from there<br />
and turning on debugging for KNewStuff(Core) like so:</p>
<p><tt style="background: #ebebeb; font-size: 13px;">QT_LOGGING_RULES="org.kde.knewstuff*=true" kcmshell5 kcm_desktoptheme</tt></p>
<p>and then watching the output, and seeing that content is being rejected<br />
by the InequalityFilter for plasma##majorversion when appropriate.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>BRANCH</strong><div><div>filter-themes-by-download-tags (branched from master)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21510">https://phabricator.kde.org/D21510</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>kcms/desktoptheme/plasma-themes.knsrc</div></div></div><br /><div><strong>To: </strong>leinir<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>