<table><tr><td style="">broulik added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19745">View Revision</a></tr></table><br /><div><div><p>Mouse buttons aren't propagated to the applet anymore, e.g. middle click on volume icon to mute no longer works.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19745#inline-120228">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AbstractItem.qml:22</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span> <span style="color: #601200">2.1</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span style="color: #304a96">import</span> <span style="color: #004012">QtQuick</span><span class="p">.</span><span style="color: #004012">Layouts</span> <span style="color: #601200">1.12</span>
</div><div style="padding: 0 8px; margin: 0 4px; "><span style="color: #304a96">import</span> <span style="color: #004012">org</span><span class="p">.</span><span style="color: #004012">kde</span><span class="p">.</span><span style="color: #004012">plasma</span><span class="p">.</span><span style="color: #004012">core</span> <span style="color: #601200">2.0</span> <span style="color: #004012">as</span> <span style="color: #004012">PlasmaCore</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">You sure this high version number is neccessary?</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19745#inline-120229">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AbstractItem.qml:30</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">h</span>eight:</span> <span class="bright"></span><span style="color: #004012"><span class="bright">effectiveItemSize</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">marginHints</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">top</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">marginHints</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">bottom</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">w</span>idth:</span> <span style="color: #004012">labelVisible</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">?</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">parent.width :</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">effectiveItemSize</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">marginHints</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">left</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">+</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">marginHints</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">right</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">Layout.fillH</span>eight:</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">!</span></span><span class="bright"></span><span class="p"><span class="bright">(</span></span><span class="bright"></span><span style="color: #004012"><span class="bright">labelVisible</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">vertical</span></span><span class="bright"></span><span class="p"><span class="bright">)</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="bright"></span><span style="color: #aa4000"><span class="bright">Layout.fillW</span>idth:</span> <span class="bright"> </span><span style="color: #004012">labelVisible</span> <span class="bright"></span><span style="color: #aa2211"><span class="bright">||</span></span><span class="bright"> </span><span style="color: #004012"><span class="bright">vertical</span></span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Avoid doing negated disjunctions for clarity: <tt style="background: #ebebeb; font-size: 13px;">!labelVisible && !vertical</tt></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19745#inline-120230">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AbstractItem.qml:74</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.preferredWidth:</span> <span style="color: #004012">abstractItem</span><span class="p">.</span><span style="color: #004012">effectiveItemSize</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.preferredHeight:</span> <span style="color: #004012">abstractItem</span><span class="p">.</span><span style="color: #004012">effectiveItemSize</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.leftMargin:</span> <span style="color: #004012">labelVisible</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">marginHints.left :</span> <span style="color: #601200">0</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">For some reason the icons are now smaller than they were before, observed on two separate computers, they used to be the same as the panel icon here:<br />
<a href="https://phabricator.kde.org/F6849506" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6849506: Screenshot_20190525_191014.png</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19745#inline-120231">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AbstractItem.qml:76</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.leftMargin:</span> <span style="color: #004012">labelVisible</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">marginHints.left :</span> <span style="color: #601200">0</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.rightMargin:</span> <span style="color: #004012">labelVisible</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">marginHints.right :</span> <span style="color: #601200">0</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #aa4000">Layout.alignment:</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">AlignVCenter</span> <span style="color: #aa2211">|</span> <span class="p">(</span><span style="color: #004012">labelVisible</span> <span style="color: #aa2211">?</span> <span style="color: #aa4000">Qt.AlignLeft :</span> <span style="color: #004012">Qt</span><span class="p">.</span><span style="color: #004012">AlignHCenter</span><span class="p">)</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This margin stuff doesn't work with right to left layout.<br />
Run <tt style="background: #ebebeb; font-size: 13px;">plasmashell -reverse</tt> and observe that there's no left padding in the item anymore:<br />
<a href="https://phabricator.kde.org/F6849504" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6849504: Screenshot_20190525_190949.png</a></p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19745#inline-120232">View Inline</a><span style="color: #4b4d51; font-weight: bold;">AbstractItem.qml:130</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">iconItem</span><span class="p">.</span><span style="color: #004012">parent</span> <span style="color: #aa2211">=</span> <span style="color: #004012">iconItemContainer</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span style="color: #004012">iconItem</span><span class="p">.</span><span style="color: #004012">anchors</span><span class="p">.</span><span style="color: #004012">fill</span> <span style="color: #aa2211">=</span> <span style="color: #004012">iconItemContainer</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Can you just make the <tt style="background: #ebebeb; font-size: 13px;">iconItem</tt> have a <tt style="background: #ebebeb; font-size: 13px;">anchors.fill: parent</tt>?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19745">https://phabricator.kde.org/D19745</a></div></div><br /><div><strong>To: </strong>ratijastk, VDG, Plasma, broulik, mart, hein, davidedmundson<br /><strong>Cc: </strong>aacid, davidre, davidedmundson, ngraham, ndavis, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>