<table><tr><td style="">broulik created this revision.<br />broulik added a reviewer: Plasma.<br />Herald added a project: Plasma.<br />Herald added a subscriber: plasma-devel.<br />broulik requested review of this revision.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21366">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>We watch the service owner so that when it dies without finishing the job we communicate an error to the user.<br />
When the job is stopped, the job is "done" and we don't need to watch the service anymore.</p></div></div><br /><div><strong>TEST PLAN</strong><div><ul class="remarkup-list">
<li class="remarkup-list-item">Started a copy, finished it, quit Dolphin: no longer got a "job unregistered" message</li>
<li class="remarkup-list-item">Started a copy, killed Dolphin: got a "application closed unexpectedly" job error</li>
<li class="remarkup-list-item">Started a copy, finished it, started a second copy, killed Dolphin, still got the error message</li>
</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>R120 Plasma Workspace</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21366">https://phabricator.kde.org/D21366</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>libnotificationmanager/jobsmodel_p.cpp<br />
libnotificationmanager/jobsmodel_p.h</div></div></div><br /><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>