<table><tr><td style="">romangg added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D21278">View Revision</a></tr></table><br /><div><div><p>Codewise looks fine. Good adaption in comparison to first revision! Question remains if we want to further disconnect/deactivate the applet functionality in case libinput is used. We don't need to watch the keyboard presses at all. Same holds for the Wayland case, where we wouldn't even need the kcminit at all (<a href="https://phabricator.kde.org/T6084" style="background-color: #e7e7e7;
          border-color: #e7e7e7;
          border-radius: 3px;
          padding: 0 4px;
          font-weight: bold;
          color: black;text-decoration: none;">T6084</a>).</p>

<p>Anyways, we can do small steps. This looks good already. Let's wait for some feedback from bug report and I would be happy with current revision.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D21278#inline-119516">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xlibtouchpad.h:63</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">bool</span> <span style="color: #004012">enabled</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">void</span> <span style="color: #004012">setTouchpadOff</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">touchpadOff</span><span class="p">)<span class="bright">;</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">int</span> <span style="color: #004012">touchpadOff</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">v<span class="bright">irtual</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">v</span>oid</span> <span style="color: #004012">setTouchpadOff</span><span class="p">(</span><span style="color: #aa4000">int</span> <span class="n">touchpadOff</span><span class="p">)<span class="bright"></span></span><span class="bright"> </span><span class="p"><span class="bright">{}</span></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="bright"></span><span class="n"><span class="bright">virtual</span></span><span class="bright"> </span><span style="color: #aa4000">int</span> <span style="color: #004012">touchpadOff</span><span class="p">()<span class="bright"></span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #601200"><span class="bright">0</span></span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Q_UNUSED</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R119 Plasma Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D21278">https://phabricator.kde.org/D21278</a></div></div><br /><div><strong>To: </strong>atulbi, romangg, davidedmundson<br /><strong>Cc: </strong>davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart<br /></div>